From: Esther Zilberberg <esty5664@gmail.com>
To: gregkh@linuxfoundation.org, arthur.stupa@gmail.com,
jannik@jrehkemper.de, william.hansen.baird@gmail.com,
kaizhetan@yahoo.com, s9430939@naver.com, straube.linux@gmail.com,
ysinghcin@gmail.com, kees@kernel.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Esther Zilberberg <esty5664@gmail.com>
Subject: [PATCH v3] staging: rtl8723bs: rename supportRateNum to support_rate_num
Date: Mon, 9 Mar 2026 09:55:43 +0000 [thread overview]
Message-ID: <20260309095543.14495-1-esty5664@gmail.com> (raw)
Rename supportRateNum to support_rate_num to fix warning
reported by checkpatch.pl.
Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
---
v1 -> v2: Rebase onto staging-next
v2 -> v3: Add missing changelog
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 +++++++++---------
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 8 ++++----
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index a631fe323157..cc197b3bb195 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -937,7 +937,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
int i, ie_len, left;
u8 wpa_ie_len;
unsigned char supportRate[16];
- int supportRateNum;
+ int support_rate_num;
unsigned short status = WLAN_STATUS_SUCCESS;
unsigned short frame_type, ie_offset = 0;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -1024,7 +1024,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
if (!p) {
/* use our own rate set as statoin used */
/* memcpy(supportRate, AP_BSSRATE, AP_BSSRATE_LEN); */
- /* supportRateNum = AP_BSSRATE_LEN; */
+ /* support_rate_num = AP_BSSRATE_LEN; */
status = WLAN_STATUS_CHALLENGE_FAIL;
goto OnAssocReqFail;
@@ -1033,25 +1033,25 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
ie_len = sizeof(supportRate);
memcpy(supportRate, p+2, ie_len);
- supportRateNum = ie_len;
+ support_rate_num = ie_len;
p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP_RATES, &ie_len,
pkt_len - WLAN_HDR_A3_LEN - ie_offset);
if (p) {
- if (supportRateNum + ie_len <= sizeof(supportRate)) {
- memcpy(supportRate+supportRateNum, p+2, ie_len);
- supportRateNum += ie_len;
+ if (support_rate_num + ie_len <= sizeof(supportRate)) {
+ memcpy(supportRate + support_rate_num, p + 2, ie_len);
+ support_rate_num += ie_len;
}
}
}
/* todo: mask supportRate between AP & STA -> move to update raid */
- /* get_matched_rate(pmlmeext, supportRate, &supportRateNum, 0); */
+ /* get_matched_rate(pmlmeext, supportRate, &support_rate_num, 0); */
/* update station supportRate */
- pstat->bssratelen = supportRateNum;
- memcpy(pstat->bssrateset, supportRate, supportRateNum);
+ pstat->bssratelen = support_rate_num;
+ memcpy(pstat->bssrateset, supportRate, support_rate_num);
update_basic_rate_table_soft_ap(pstat->bssrateset, pstat->bssratelen);
/* check RSN/WPA/WPS */
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index cffb1a9d36fa..6a7c09db4cd9 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -1595,7 +1595,7 @@ int update_sta_support_rate(struct adapter *padapter, u8 *pvar_ie, uint var_ie_l
{
unsigned int ie_len;
struct ndis_80211_var_ie *pIE;
- int supportRateNum = 0;
+ int support_rate_num = 0;
struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
@@ -1606,11 +1606,11 @@ int update_sta_support_rate(struct adapter *padapter, u8 *pvar_ie, uint var_ie_l
return _FAIL;
memcpy(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates, pIE->data, ie_len);
- supportRateNum = ie_len;
+ support_rate_num = ie_len;
pIE = (struct ndis_80211_var_ie *)rtw_get_ie(pvar_ie, WLAN_EID_EXT_SUPP_RATES, &ie_len, var_ie_len);
- if (pIE && (ie_len <= sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates) - supportRateNum))
- memcpy((pmlmeinfo->FW_sta_info[cam_idx].SupportedRates + supportRateNum), pIE->data, ie_len);
+ if (pIE && (ie_len <= sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates) - support_rate_num))
+ memcpy((pmlmeinfo->FW_sta_info[cam_idx].SupportedRates + support_rate_num), pIE->data, ie_len);
return _SUCCESS;
}
--
2.43.0
next reply other threads:[~2026-03-09 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 9:55 Esther Zilberberg [this message]
2026-03-09 19:49 ` [PATCH v3] staging: rtl8723bs: rename supportRateNum to support_rate_num Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309095543.14495-1-esty5664@gmail.com \
--to=esty5664@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannik@jrehkemper.de \
--cc=kaizhetan@yahoo.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=william.hansen.baird@gmail.com \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox