From: Greg KH <gregkh@linuxfoundation.org>
To: Soham Kute <officialsohamkute@gmail.com>
Cc: andy@kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: replace -1 with proper error codes
Date: Mon, 9 Mar 2026 17:27:57 +0100 [thread overview]
Message-ID: <2026030916-spring-pawing-9370@gregkh> (raw)
In-Reply-To: <20260228202701.43337-1-officialsohamkute@gmail.com>
On Sun, Mar 01, 2026 at 01:57:01AM +0530, Soham Kute wrote:
> Replace return -1 with proper kernel error codes:
> - -ENODEV when SPI device is NULL
> - -EINVAL when display size or buffer is invalid
> - -EOPNOTSUPP for unimplemented functions
>
> Signed-off-by: Soham Kute <officialsohamkute@gmail.com>
> ---
> drivers/staging/fbtft/fb_ra8875.c | 4 ++--
> drivers/staging/fbtft/fbtft-bus.c | 4 ++--
> drivers/staging/fbtft/fbtft-io.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
Some of these functions are not called anywhere, so please remove them
instead entirely, and then fix up the remaining ones (after verifying
that the callers can handle the changed values you have made here.)
That can be a patch series.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-09 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 20:27 [PATCH] staging: fbtft: replace -1 with proper error codes Soham Kute
2026-03-09 16:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026030916-spring-pawing-9370@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=officialsohamkute@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox