From: "Bera Yüzlü" <b9788213@gmail.com>
To: gregkh@linuxfoundation.org
Cc: straube.linux@gmail.com, Yeking@Red54.com, hansg@kernel.org,
andriy.shevchenko@linux.intel.com, ethantidmore06@gmail.com,
weibu@redadmin.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, "Bera Yüzlü" <b9788213@gmail.com>
Subject: [PATCH v2] staging: rtl8723bs: change custom comparing function to strcmp()
Date: Mon, 9 Mar 2026 21:45:56 +0300 [thread overview]
Message-ID: <20260309184556.846-2-b9788213@gmail.com> (raw)
eqNByte() function is a redundant reimplementation of strcmp().
Remove eqNByte() and switch its usages to strcmp().
No functional change.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
---
V2: Used strcmp() instead of memcmp()
V1 link: https://lore.kernel.org/linux-staging/20260227200637.47130-1-b9788213@gmail.com/
drivers/staging/rtl8723bs/hal/hal_com.c | 12 ------------
.../staging/rtl8723bs/hal/hal_com_phycfg.c | 19 ++++++++++---------
drivers/staging/rtl8723bs/include/hal_com.h | 2 --
3 files changed, 10 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 31b3e880a..a7720f821 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -750,18 +750,6 @@ void SetHalODMVar(
}
-bool eqNByte(u8 *str1, u8 *str2, u32 num)
-{
- if (num == 0)
- return false;
- while (num > 0) {
- num--;
- if (str1[num] != str2[num])
- return false;
- }
- return true;
-}
-
bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)
{
u16 i = 0;
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index dc2da49e6..61c6b6e10 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -8,6 +8,7 @@
#include <drv_types.h>
#include <hal_data.h>
#include <linux/kernel.h>
+#include <linux/string.h>
u8 PHY_GetTxPowerByRateBase(struct adapter *Adapter, u8 RfPath,
enum rate_section RateSection)
@@ -819,27 +820,27 @@ void PHY_SetTxPowerLimit(
powerLimit = powerLimit > MAX_POWER_INDEX ? MAX_POWER_INDEX : powerLimit;
- if (eqNByte(Regulation, (u8 *)("FCC"), 3))
+ if (strcmp(Regulation, "FCC") == 0)
regulation = 0;
- else if (eqNByte(Regulation, (u8 *)("MKK"), 3))
+ else if (strcmp(Regulation, "MKK") == 0)
regulation = 1;
- else if (eqNByte(Regulation, (u8 *)("ETSI"), 4))
+ else if (strcmp(Regulation, "ETSI") == 0)
regulation = 2;
- else if (eqNByte(Regulation, (u8 *)("WW13"), 4))
+ else if (strcmp(Regulation, "WW13") == 0)
regulation = 3;
- if (eqNByte(RateSection, (u8 *)("CCK"), 3) && eqNByte(RfPath, (u8 *)("1T"), 2))
+ if (strcmp(RateSection, "CCK") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 0;
- else if (eqNByte(RateSection, (u8 *)("OFDM"), 4) && eqNByte(RfPath, (u8 *)("1T"), 2))
+ else if (strcmp(RateSection, "OFDM") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 1;
- else if (eqNByte(RateSection, (u8 *)("HT"), 2) && eqNByte(RfPath, (u8 *)("1T"), 2))
+ else if (strcmp(RateSection, "HT") == 0 && strcmp(RfPath, "1T") == 0)
rateSection = 2;
else
return;
- if (eqNByte(Bandwidth, (u8 *)("20M"), 3))
+ if (strcmp(Bandwidth, "20M") == 0)
bandwidth = 0;
- else if (eqNByte(Bandwidth, (u8 *)("40M"), 3))
+ else if (strcmp(Bandwidth, "40M") == 0)
bandwidth = 1;
channelIndex = phy_GetChannelIndexOfTxPowerLimit(channel);
diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h
index 74d6c892c..483f0390a 100644
--- a/drivers/staging/rtl8723bs/include/hal_com.h
+++ b/drivers/staging/rtl8723bs/include/hal_com.h
@@ -141,8 +141,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter);
u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,
void *value);
-bool eqNByte(u8 *str1, u8 *str2, u32 num);
-
bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in);
#define HWSET_MAX_SIZE 512
--
2.43.0
next reply other threads:[~2026-03-09 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 18:45 Bera Yüzlü [this message]
2026-03-17 8:15 ` [PATCH v2] staging: rtl8723bs: change custom comparing function to strcmp() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309184556.846-2-b9788213@gmail.com \
--to=b9788213@gmail.com \
--cc=Yeking@Red54.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
--cc=weibu@redadmin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox