Re: [PATCH] staging: greybus: loopback: remove unused macro argument

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 08, 2026 at 06:44:44PM -0600, sluisr wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Argument 'conn' is not used in function-like macro
> 
> The gb_dev_loopback_ro_attr macro accepted a 'conn' argument which was
> never used in its expansion. The argument was removed from the macro
> definition and its invocation.
> 
> Signed-off-by: sluisr <contact@sluisr.com>
> ---
>  drivers/staging/greybus/loopback.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index aa9c73cb0..855d5051c 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -193,7 +193,7 @@ static ssize_t field##_store(struct device *dev,			\
>  }									\
>  static DEVICE_ATTR_RW(field)
>  
> -#define gb_dev_loopback_ro_attr(field, conn)				\
> +#define gb_dev_loopback_ro_attr(field)				\
>  static ssize_t field##_show(struct device *dev,		\
>  			    struct device_attribute *attr,		\
>  			    char *buf)					\
> @@ -305,7 +305,7 @@ gb_dev_loopback_rw_attr(us_wait, d);
>  /* Maximum iterations for a given operation: 1-(2^32-1), 0 implies infinite */
>  gb_dev_loopback_rw_attr(iteration_max, u);
>  /* The current index of the for (i = 0; i < iteration_max; i++) loop */
> -gb_dev_loopback_ro_attr(iteration_count, false);
> +gb_dev_loopback_ro_attr(iteration_count);
>  /* A flag to indicate synchronous or asynchronous operations */
>  gb_dev_loopback_rw_attr(async, u);
>  /* Timeout of an individual asynchronous request */
> -- 
> 2.53.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file,
  Documentation/process/submitting-patches.rst for how to do this
  correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot