Re: [PATCH 1/4] staging: rtl8723bs: replace rtw_if_up() return type to bool

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 07, 2026 at 06:58:30PM +0300, Nikolay Kulikov wrote:
> Function rtw_if_up() actually return 'bool' value, but it's type is
> 'signed int'. Replace 'signed int' with 'bool' to make it more accurate.
> 
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c    | 6 ++----
>  drivers/staging/rtl8723bs/include/rtw_mlme.h | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 28dfb974fdff..85ec172d6a89 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -262,15 +262,13 @@ void rtw_free_network_queue(struct adapter *padapter, u8 isfreeall)
>  	spin_unlock_bh(&scanned_queue->lock);
>  }
>  
> -signed int rtw_if_up(struct adapter *padapter)
> +bool rtw_if_up(struct adapter *padapter)
>  {
> -	signed int res;
> +	bool res = true;
>  
>  	if (padapter->bDriverStopped || padapter->bSurpriseRemoved ||
>  		!check_fwstate(&padapter->mlmepriv, _FW_LINKED))
>  		res = false;
> -	else
> -		res =  true;
>  
>  	return res;

No need for res at all, just return true/false instead?

thanks,

greg k-h