From: Mark Adamenko <marusik.adamenko@gmail.com>
To: linux-staging@lists.linux.dev
Cc: parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Mark Adamenko <marusik.adamenko@gmail.com>
Subject: [PATCH] staging: most: dim2: remove BUG_ON() calls
Date: Mon, 9 Mar 2026 18:33:04 -0700 [thread overview]
Message-ID: <20260310013304.39169-1-marusik.adamenko@gmail.com> (raw)
All BUG_ON() calls in this file are redundant either because of
impossible conditions or prior error handling. Remove all BUG_ON()
calls.
Signed-off-by: Mark Adamenko <marusik.adamenko@gmail.com>
---
drivers/staging/most/dim2/dim2.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index 66617e89e028..c8fdc6a52467 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -165,9 +165,6 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
unsigned long flags;
struct dim_ch_state st;
- BUG_ON(!hdm_ch);
- BUG_ON(!hdm_ch->is_initialized);
-
spin_lock_irqsave(&dim_lock, flags);
if (list_empty(head)) {
spin_unlock_irqrestore(&dim_lock, flags);
@@ -187,7 +184,6 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch)
return -EAGAIN;
}
- BUG_ON(mbo->bus_address == 0);
if (!dim_enqueue_buffer(&hdm_ch->ch, mbo->bus_address, buf_size)) {
list_del(head->next);
spin_unlock_irqrestore(&dim_lock, flags);
@@ -268,9 +264,6 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx)
unsigned long flags;
u8 *data;
- BUG_ON(!hdm_ch);
- BUG_ON(!hdm_ch->is_initialized);
-
spin_lock_irqsave(&dim_lock, flags);
done_buffers = dim_get_channel_state(&hdm_ch->ch, &st)->done_buffers;
@@ -454,8 +447,6 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx,
int const ch_addr = ch_idx * 2 + 2;
struct hdm_channel *const hdm_ch = dev->hch + ch_idx;
- BUG_ON(ch_idx < 0 || ch_idx >= DMA_CHANNELS);
-
if (hdm_ch->is_initialized)
return -EPERM;
@@ -566,8 +557,6 @@ static int enqueue(struct most_interface *most_iface, int ch_idx,
struct hdm_channel *hdm_ch = dev->hch + ch_idx;
unsigned long flags;
- BUG_ON(ch_idx < 0 || ch_idx >= DMA_CHANNELS);
-
if (!hdm_ch->is_initialized)
return -EPERM;
@@ -642,8 +631,6 @@ static int poison_channel(struct most_interface *most_iface, int ch_idx)
u8 hal_ret;
int ret = 0;
- BUG_ON(ch_idx < 0 || ch_idx >= DMA_CHANNELS);
-
if (!hdm_ch->is_initialized)
return -EPERM;
--
2.53.0
next reply other threads:[~2026-03-10 1:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 1:33 Mark Adamenko [this message]
2026-03-18 15:28 ` [PATCH] staging: most: dim2: remove BUG_ON() calls Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310013304.39169-1-marusik.adamenko@gmail.com \
--to=marusik.adamenko@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox