[PATCH] staging: rtl8723bs: Remove dead code

[PATCH] staging: rtl8723bs: Remove dead code

[Bera Yüzlü]

Clean up the dm_odm_t structure by removing commented-out members and
related legacy comments.

Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm.h | 33 -----------------------------
 1 file changed, 33 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 38830552d..d77763d28 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -650,10 +650,6 @@ struct ant_detected_info {
 /*  2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */
 /*  */
 struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
-	/* struct timer_list	FastAntTrainingTimer; */
-	/*  */
-	/* 	Add for different team use temporarily */
-	/*  */
 	struct adapter *Adapter;		/*  For CE/NIC team */
 	/*  WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */
 	bool odm_ready;
@@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
 	u8 ControlChannel;
 /*  ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */
 
-/* REMOVED COMMON INFO---------- */
-	/* u8 		PseudoMacPhyMode; */
-	/* bool			*BTCoexist; */
-	/* bool			PseudoBtCoexist; */
-	/* u8 		OPMode; */
-	/* bool			bAPMode; */
-	/* bool			bClientMode; */
-	/* bool			bAdHocMode; */
-	/* bool			bSlaveOfDMSP; */
-/* REMOVED COMMON INFO---------- */
-
 /* 1  COMMON INFORMATION */
 
 	/*  */
@@ -871,13 +856,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
 	struct odm_mac_status_info *pMacInfo;
 	/* MAC_INFO_88E		MacInfo; */
 
-	/*  Different Team independent structure?? */
-
-	/*  */
-	/* TX_RTP_CMN		TX_retrpo; */
-	/* TX_RTP_88E		TX_retrpo; */
-	/* TX_RTP_8195		TX_retrpo; */
-
 	/*  */
 	/* ODM Structure */
 	/*  */
@@ -901,17 +879,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
 	/*  ================================================== */
 	/*  */
 
-	/* common */
-	/* u8 DM_Type; */
-	/* u8    PSD_Report_RXHP[80];    Add By Gary */
-	/* u8    PSD_func_flag;                Add By Gary */
-	/* for DIG */
-	/* u8 bDMInitialGainEnable; */
-	/* u8 binitialized;  for dm_initial_gain_Multi_STA use. */
-	/* for Antenna diversity */
-	/* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */
-	/* PSTA_INFO_T RSSI_target; */
-
 	bool *pbDriverStopped;
 	bool *pbDriverIsGoingToPnpSetPowerSleep;
 	bool *pinit_adpt_in_progress;
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: Remove dead code

[Ethan Tidmore]

On Thu Mar 12, 2026 at 7:53 AM CDT, Bera Yüzlü wrote:
> Clean up the dm_odm_t structure by removing commented-out members and
> related legacy comments.
>
> Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

Re: [PATCH] staging: rtl8723bs: Remove dead code

[Greg KH]

On Thu, Mar 12, 2026 at 03:53:38PM +0300, Bera Yüzlü wrote:
> Clean up the dm_odm_t structure by removing commented-out members and
> related legacy comments.
> 
> Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/odm.h | 33 -----------------------------
>  1 file changed, 33 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
> index 38830552d..d77763d28 100644
> --- a/drivers/staging/rtl8723bs/hal/odm.h
> +++ b/drivers/staging/rtl8723bs/hal/odm.h
> @@ -650,10 +650,6 @@ struct ant_detected_info {
>  /*  2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */
>  /*  */
>  struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
> -	/* struct timer_list	FastAntTrainingTimer; */
> -	/*  */
> -	/* 	Add for different team use temporarily */
> -	/*  */
>  	struct adapter *Adapter;		/*  For CE/NIC team */
>  	/*  WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */
>  	bool odm_ready;
> @@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
>  	u8 ControlChannel;
>  /*  ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */
>  
> -/* REMOVED COMMON INFO---------- */
> -	/* u8 		PseudoMacPhyMode; */
> -	/* bool			*BTCoexist; */
> -	/* bool			PseudoBtCoexist; */
> -	/* u8 		OPMode; */
> -	/* bool			bAPMode; */
> -	/* bool			bClientMode; */
> -	/* bool			bAdHocMode; */
> -	/* bool			bSlaveOfDMSP; */
> -/* REMOVED COMMON INFO---------- */
> -
>  /* 1  COMMON INFORMATION */
>  
>  	/*  */
> @@ -871,13 +856,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
>  	struct odm_mac_status_info *pMacInfo;
>  	/* MAC_INFO_88E		MacInfo; */
>  
> -	/*  Different Team independent structure?? */
> -
> -	/*  */
> -	/* TX_RTP_CMN		TX_retrpo; */
> -	/* TX_RTP_88E		TX_retrpo; */
> -	/* TX_RTP_8195		TX_retrpo; */
> -
>  	/*  */
>  	/* ODM Structure */
>  	/*  */
> @@ -901,17 +879,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
>  	/*  ================================================== */
>  	/*  */
>  
> -	/* common */

This line should not have been removed, right?

thanks,

greg k-h