From: Greg KH <gregkh@linuxfoundation.org>
To: Rahul Joshi <rj5547884@gmail.com>
Cc: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: uart: replace DEFINE_IDR with DEFINE_XARRAY_ALLOC
Date: Thu, 12 Mar 2026 06:10:52 +0100 [thread overview]
Message-ID: <2026031227-stubborn-cymbal-e83a@gregkh> (raw)
In-Reply-To: <20260311194200.542783-1-rj5547884@gmail.com>
On Thu, Mar 12, 2026 at 01:12:00AM +0530, Rahul Joshi wrote:
> DEFINE_IDR is deprecated in favour of DEFINE_XARRAY_ALLOC. Replace the
> tty_minors IDR with an XArray and update all call sites:
>
> idr_alloc() -> xa_alloc()
> idr_find() -> xa_load()
> idr_remove() -> xa_erase()
> idr_destroy() -> xa_destroy()
>
> Also remove the now-unused <linux/idr.h> include and add
> <linux/xarray.h>.
>
> Signed-off-by: Rahul Joshi <rj5547884@gmail.com>
> ---
> drivers/staging/greybus/uart.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
I am pretty sure I have rejected this same patch multiple times in the
past. Please see the mailing list archives for why.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-12 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:42 [PATCH] staging: greybus: uart: replace DEFINE_IDR with DEFINE_XARRAY_ALLOC Rahul Joshi
2026-03-12 5:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031227-stubborn-cymbal-e83a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rj5547884@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox