From: Greg KH <gregkh@linuxfoundation.org>
To: Giacomo Di Clerico <giacomodiclerico@gmail.com>
Cc: akhilesh@ee.iitb.ac.in, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: fix missing blank line after declaration
Date: Sun, 15 Mar 2026 07:54:50 +0100 [thread overview]
Message-ID: <2026031510-answering-rack-fe40@gregkh> (raw)
In-Reply-To: <20260314220503.35991-1-giacomodiclerico@gmail.com>
On Sat, Mar 14, 2026 at 11:05:03PM +0100, Giacomo Di Clerico wrote:
> Add a blank line between the last variable declaration and the
> function pointer declaration in struct tsi148_driver, as required
> by the kernel coding style.
>
> Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
> ---
> drivers/staging/vme_user/vme_tsi148.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index f73ac92320bb..3102b94a0a86 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
> void __iomem *base; /* Base Address of device registers */
> wait_queue_head_t dma_queue[2];
> wait_queue_head_t iack_queue;
> +
> void (*lm_callback[4])(void *); /* Called in interrupt handler */
> void *lm_data[4];
> void *crcsr_kernel;
This is all a list of variables, no need for an extra line here.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-15 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 22:05 [PATCH] staging: vme_user: fix missing blank line after declaration Giacomo Di Clerico
2026-03-15 6:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031510-answering-rack-fe40@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akhilesh@ee.iitb.ac.in \
--cc=giacomodiclerico@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox