From: Marcos Andrade <marcosandrade95963@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ethan Tidmore <ethantidmore06@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Marcos Andrade <marcosandrade95963@gmail.com>
Subject: [PATCH v5 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros
Date: Mon, 16 Mar 2026 19:19:23 -0300 [thread overview]
Message-ID: <20260316221924.4904-2-marcosandrade95963@gmail.com> (raw)
In-Reply-To: <20260316221924.4904-1-marcosandrade95963@gmail.com>
Replace hardcoded magic numbers for network protocols (e.g., 0x0806
for ARP, 0x888e for EAPOL) with their standard EtherType macro
equivalents (ETH_P_ARP, ETH_P_PAE) defined in <linux/if_ether.h>.
This change improves code readability and aligns the driver with
standard Linux networking definitions.
Signed-off-by: Marcos Andrade <marcosandrade95963@gmail.com>
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7b18be891..4062fe0c1 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -5,6 +5,7 @@
*
******************************************************************************/
#include <drv_types.h>
+#include <linux/if_ether.h>
static u8 P802_1H_OUI[P80211_OUI_LEN] = { 0x00, 0x00, 0xf8 };
static u8 RFC1042_OUI[P80211_OUI_LEN] = { 0x00, 0x00, 0x00 };
@@ -2026,8 +2027,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *xmitframe)
if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_SPECIAL) {
struct pkt_attrib *attrib = &xmitframe->attrib;
- if (attrib->ether_type == 0x0806 ||
- attrib->ether_type == 0x888e ||
+ if (attrib->ether_type == ETH_P_ARP ||
+ attrib->ether_type == ETH_P_PAE ||
attrib->dhcp_pkt
)
allow = true;
--
2.53.0
next prev parent reply other threads:[~2026-03-16 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:19 [PATCH v5 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c Marcos Andrade
2026-03-16 22:19 ` Marcos Andrade [this message]
2026-03-16 22:19 ` [PATCH v5 2/2] staging: rtl8723bs: Replace msleep() with fsleep() Marcos Andrade
2026-03-17 11:43 ` [PATCH v5 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316221924.4904-2-marcosandrade95963@gmail.com \
--to=marcosandrade95963@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox