From: Archit Anant <architanant5@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Archit Anant <architanant5@gmail.com>
Subject: [PATCH v5 0/4] iio: adc: ad799x: modernize resource management
Date: Wed, 18 Mar 2026 14:57:11 +0530 [thread overview]
Message-ID: <20260318092715.42538-1-architanant5@gmail.com> (raw)
This series modernizes the ad799x driver by converting resource
management to the devm_ infrastructure. This results in cleaner
probe error handling, the removal of the ad799x_remove() function,
and improved code maintainability.
Key changes in this series include:
- Static allocation of the rx_buf using IIO_DECLARE_BUFFER_WITH_TS()
to avoid dynamic memory leaks during scan mode updates.
- Caching of VCC and VREF regulator voltages during probe() to
optimize read_raw() performance and simplify power management logic.
- Migration of regulators and mutex initialization to device-managed
resources (devm).
- Removal of the manual ad799x_remove() function and all goto-based
error cleanup labels in ad799x_probe().
These changes ensure the teardown sequence is always correct,
following the reverse order of allocation, and remove unnecessary
boilerplate code from the driver.
Changes in v5:
- Used devm_add_action_or_reset() for regulator disabling instead of
devm_regulator_get_enable_read_voltage() as suggested by Jonathan
Cameron. This was necessary to preserve the regulator pointers (st->reg
and st->vref) required by the driver's suspend/resume power management
callbacks.
- Simplified voltage caching to use a single 'vref_uV' variable.
- Converted mutex_init() to devm_mutex_init().
- Resolved error path ordering issues by using devm_* exclusively,
allowing for the complete removal of the ad799x_remove() function.
Changes in v4:
- Simplified voltage caching to use a single 'vref_uV' variable as
suggested by David Lechner.
- Capitalized 'uV' in variable names as suggested by Andy Shevchenko.
- Removed redundant 'if (ret < 0)' check in read_raw() (dead check).
- Used devm_mutex_init() to replace manual mutex handling.
- Introduced a local 'dev' pointer in probe() to simplify function calls.
- Switched to IIO_DECLARE_BUFFER_WITH_TS() for the buffer declaration.
- Moved goto removals into the respective patches where devm conversion
occurs.
Changes in v3:
- Split the monolithic v2 patch into 4 logical commits as requested by
Andy Shevchenko.
Changes in v2:
- Eliminated dynamic buffer allocation (feedback from David Lechner).
- Cached voltages to prevent devm/manual ordering hazards (feedback
from Jonathan Cameron).
Archit Anant (4):
iio: adc: ad799x: use local device pointer in probe
iio: adc: ad799x: use a static buffer for scan data
iio: adc: ad799x: cache regulator voltages during probe
iio: adc: ad799x: use devm_iio_device_register and drop remove()
drivers/iio/adc/ad799x.c | 106 ++++++++++++++++++---------------------
1 file changed, 49 insertions(+), 57 deletions(-)
--
2.39.5
next reply other threads:[~2026-03-18 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 9:27 Archit Anant [this message]
2026-03-18 9:27 ` [PATCH v5 1/4] iio: adc: ad799x: use local device pointer in probe Archit Anant
2026-03-18 9:27 ` [PATCH v5 2/4] iio: adc: ad799x: use a static buffer for scan data Archit Anant
2026-03-18 9:27 ` [PATCH v5 3/4] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-03-18 14:40 ` Andy Shevchenko
2026-03-19 2:36 ` Archit Anant
2026-03-21 18:27 ` Jonathan Cameron
2026-03-23 7:55 ` Andy Shevchenko
2026-03-23 12:22 ` Archit Anant
2026-03-23 14:39 ` David Lechner
2026-03-23 17:55 ` Jonathan Cameron
2026-03-24 17:20 ` Archit Anant
2026-03-18 9:27 ` [PATCH v5 4/4] iio: adc: ad799x: use devm_iio_device_register and drop remove() Archit Anant
2026-03-18 14:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260318092715.42538-1-architanant5@gmail.com \
--to=architanant5@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox