From: kernel test robot <lkp@intel.com>
To: Oskar Ray-Frayssinet <rayfraytech@gmail.com>, gregkh@linuxfoundation.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
straube.linux@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Oskar Ray-Frayssinet <rayfraytech@gmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in single statement blocks
Date: Wed, 18 Mar 2026 21:48:16 +0800 [thread overview]
Message-ID: <202603182154.qP1dKSZf-lkp@intel.com> (raw)
In-Reply-To: <20260317203715.7430-1-rayfraytech@gmail.com>
Hi Oskar,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Oskar-Ray-Frayssinet/staging-rtl8723bs-remove-unnecessary-braces-in-single-statement-blocks/20260318-121311
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260317203715.7430-1-rayfraytech%40gmail.com
patch subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in single statement blocks
config: sparc64-allmodconfig (https://download.01.org/0day-ci/archive/20260318/202603182154.qP1dKSZf-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182154.qP1dKSZf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603182154.qP1dKSZf-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:131:4: error: expected expression
131 | else
| ^
>> drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:153:1: error: function definition is not allowed here
153 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:171:1: error: function definition is not allowed here
171 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:182:1: error: function definition is not allowed here
182 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:213:1: error: function definition is not allowed here
213 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:277:1: error: function definition is not allowed here
277 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:400:1: error: function definition is not allowed here
400 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:413:1: error: function definition is not allowed here
413 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:424:1: error: function definition is not allowed here
424 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:439:1: error: function definition is not allowed here
439 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:456:1: error: function definition is not allowed here
456 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:471:1: error: function definition is not allowed here
471 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:486:1: error: function definition is not allowed here
486 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:505:1: error: function definition is not allowed here
505 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:519:1: error: function definition is not allowed here
519 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:528:1: error: function definition is not allowed here
528 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:542:1: error: function definition is not allowed here
542 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:561:1: error: function definition is not allowed here
561 | {
| ^
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:615:1: error: function definition is not allowed here
615 | {
| ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +131 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
82
83 static u8 halbtc8723b2ant_WifiRssiState(
84 struct btc_coexist *pBtCoexist,
85 u8 index,
86 u8 levelNum,
87 u8 rssiThresh,
88 u8 rssiThresh1
89 )
90 {
91 s32 wifiRssi = 0;
92 u8 wifiRssiState = pCoexSta->preWifiRssiState[index];
93
94 pBtCoexist->fBtcGet(pBtCoexist, BTC_GET_S4_WIFI_RSSI, &wifiRssi);
95
96 if (levelNum == 2) {
97 if (
98 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_LOW) ||
99 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_LOW)
100 ) {
101 if (wifiRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
102 wifiRssiState = BTC_RSSI_STATE_HIGH;
103 else
104 wifiRssiState = BTC_RSSI_STATE_STAY_LOW;
105 } else {
106 if (wifiRssi < rssiThresh)
107 wifiRssiState = BTC_RSSI_STATE_LOW;
108 else
109 wifiRssiState = BTC_RSSI_STATE_STAY_HIGH;
110 }
111 } else if (levelNum == 3) {
112 if (rssiThresh > rssiThresh1)
113 return pCoexSta->preWifiRssiState[index];
114
115 if (
116 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_LOW) ||
117 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_LOW)
118 ) {
119 if (wifiRssi >= (rssiThresh + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
120 wifiRssiState = BTC_RSSI_STATE_MEDIUM;
121 else
122 wifiRssiState = BTC_RSSI_STATE_STAY_LOW;
123 } else if (
124 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_MEDIUM) ||
125 (pCoexSta->preWifiRssiState[index] == BTC_RSSI_STATE_STAY_MEDIUM)
126 ) {
127 if (wifiRssi >= (rssiThresh1 + BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT))
128 wifiRssiState = BTC_RSSI_STATE_HIGH;
129 else if (wifiRssi < rssiThresh) {
130 wifiRssiState = BTC_RSSI_STATE_LOW;
> 131 else
132 wifiRssiState = BTC_RSSI_STATE_STAY_MEDIUM;
133 } else {
134 if (wifiRssi < rssiThresh1)
135 wifiRssiState = BTC_RSSI_STATE_MEDIUM;
136 else
137 wifiRssiState = BTC_RSSI_STATE_STAY_HIGH;
138 }
139 }
140
141 pCoexSta->preWifiRssiState[index] = wifiRssiState;
142
143 return wifiRssiState;
144 }
145
146 static void halbtc8723b2ant_LimitedRx(
147 struct btc_coexist *pBtCoexist,
148 bool bForceExec,
149 bool bRejApAggPkt,
150 bool bBtCtrlAggBufSize,
151 u8 aggBufSize
152 )
> 153 {
154 bool bRejectRxAgg = bRejApAggPkt;
155 bool bBtCtrlRxAggSize = bBtCtrlAggBufSize;
156 u8 rxAggSize = aggBufSize;
157
158 /* */
159 /* Rx Aggregation related setting */
160 /* */
161 pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_BL_TO_REJ_AP_AGG_PKT, &bRejectRxAgg);
162 /* decide BT control aggregation buf size or not */
163 pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_BL_BT_CTRL_AGG_SIZE, &bBtCtrlRxAggSize);
164 /* aggregation buf size, only work when BT control Rx aggregation size. */
165 pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_U1_AGG_BUF_SIZE, &rxAggSize);
166 /* real update aggregation setting */
167 pBtCoexist->fBtcSet(pBtCoexist, BTC_SET_ACT_AGGREGATE_CTRL, NULL);
168 }
169
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-03-18 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 20:37 [PATCH] staging: rtl8723bs: remove unnecessary braces in single statement blocks Oskar Ray-Frayssinet
2026-03-18 13:04 ` kernel test robot
2026-03-18 13:48 ` kernel test robot [this message]
2026-03-18 15:57 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 23:30 Oskar Ray-Frayssinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603182154.qP1dKSZf-lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rayfraytech@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox