Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: sm750fb: fix CamelCase naming crimes
Date: Wed, 18 Mar 2026 16:25:57 +0100	[thread overview]
Message-ID: <2026031847-resilient-handwash-6f4d@gregkh> (raw)
In-Reply-To: <20260317174226.167865-1-inasj268@gmail.com>

On Tue, Mar 17, 2026 at 05:42:26PM +0000, Jad Keskes wrote:
> The sm750fb driver had several variables using CamelCase, which is
> discouraged in the Linux kernel coding style.
> 
> Rename the following variables to use snake_case:
> - pvMem -> pv_mem
> - pvReg -> pv_reg

Please look at these names, "pv" was trying to use "Hungarian notation"
and describe a void pointer.  That's not a proper way to name a kernel
variable, so pick a correct one instead.

Also, it's usually best if you rename one structure at a time.

thanks,

greg k-h

      reply	other threads:[~2026-03-18 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 17:42 [PATCH] staging: sm750fb: fix CamelCase naming crimes Jad Keskes
2026-03-18 15:25 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026031847-resilient-handwash-6f4d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=inasj268@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox