* [PATCH] staging: greybus: gpio: add comment to mutex definition
@ 2026-03-11 17:53 Rahul Joshi
2026-03-18 15:30 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Joshi @ 2026-03-11 17:53 UTC (permalink / raw)
To: rmfrfs, johan, elder, gregkh
Cc: greybus-dev, linux-staging, linux-kernel, Rahul Joshi
The irq_lock mutex is missing a comment describing what it protects,
which is required by kernel coding style. Add a comment clarifying
that it serializes IRQ bus lock/unlock operations used to defer and
sync pending IRQ type and mask changes to hardware.
Signed-off-by: Rahul Joshi <rj5547884@gmail.com>
---
drivers/staging/greybus/gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 12185f7a982c..89c15b804b2a 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -39,7 +39,7 @@ struct gb_gpio_controller {
struct gpio_chip chip;
struct irq_chip irqc;
- struct mutex irq_lock;
+ struct mutex irq_lock; /* protects irq bus operations */
};
static struct gpio_chip *irq_data_to_gpio_chip(struct irq_data *d)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: gpio: add comment to mutex definition
2026-03-11 17:53 [PATCH] staging: greybus: gpio: add comment to mutex definition Rahul Joshi
@ 2026-03-18 15:30 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-03-18 15:30 UTC (permalink / raw)
To: Rahul Joshi
Cc: rmfrfs, johan, elder, greybus-dev, linux-staging, linux-kernel
On Wed, Mar 11, 2026 at 11:23:34PM +0530, Rahul Joshi wrote:
> The irq_lock mutex is missing a comment describing what it protects,
> which is required by kernel coding style. Add a comment clarifying
> that it serializes IRQ bus lock/unlock operations used to defer and
> sync pending IRQ type and mask changes to hardware.
>
> Signed-off-by: Rahul Joshi <rj5547884@gmail.com>
> ---
> drivers/staging/greybus/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
> index 12185f7a982c..89c15b804b2a 100644
> --- a/drivers/staging/greybus/gpio.c
> +++ b/drivers/staging/greybus/gpio.c
> @@ -39,7 +39,7 @@ struct gb_gpio_controller {
>
> struct gpio_chip chip;
> struct irq_chip irqc;
> - struct mutex irq_lock;
> + struct mutex irq_lock; /* protects irq bus operations */
What is a "irq bus"? This comment feels odd to me :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 17:53 [PATCH] staging: greybus: gpio: add comment to mutex definition Rahul Joshi
2026-03-18 15:30 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox