public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: split multiple assignment in rtw_mgmt_xmitframe_coalesce
@ 2026-03-19  6:26 Marco Antonio Solis Segura
  0 siblings, 0 replies; only message in thread
From: Marco Antonio Solis Segura @ 2026-03-19  6:26 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging, linux-kernel, Marco Antonio Solis Segura

Cleanup the multiple assignment of tmp_buf and BIP_AAD to fix the
checkpatch.pl CHECK: "Multiple assignments should be avoided".

Additionally, reorder the assignments to ensure tmp_buf is assigned
only after BIP_AAD has been validated as non-NULL.

Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 19758e2f5903..d75f60efb7b6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -1194,12 +1194,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s
 	pwlanhdr = (struct ieee80211_hdr *)pframe;
 
 	ori_len = BIP_AAD_SIZE + pattrib->pktlen;
-	tmp_buf = BIP_AAD = kzalloc(ori_len, GFP_ATOMIC);
-	subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */
+	BIP_AAD = kzalloc(ori_len, GFP_ATOMIC);
 
 	if (!BIP_AAD)
 		return _FAIL;
 
+	tmp_buf = BIP_AAD;
+	subtype = GetFrameSubType(pframe); /* bit(7)~bit(2) */
 	spin_lock_bh(&padapter->security_key_mutex);
 
 	/* only support station mode */
-- 
2.53.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-19  6:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19  6:26 [PATCH] staging: rtl8723bs: split multiple assignment in rtw_mgmt_xmitframe_coalesce Marco Antonio Solis Segura

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox