* [PATCH] staging: rtl8723bs: simplify condition in rtw_btcoex_MediaStatusNotify
@ 2026-03-19 7:40 Zile Xiong
2026-03-19 7:54 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Zile Xiong @ 2026-03-19 7:40 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, karanja99erick, Zile Xiong
Remove redundant parentheses and unnecessary comparison to true
in the conditional expression to improve readability.
No functional change.
Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index f4b19ef7b341..b19eab0afba3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -10,10 +10,8 @@
void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
{
- if ((media_status == RT_MEDIA_CONNECT)
- && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
+ if (media_status == RT_MEDIA_CONNECT && check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE))
rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
- }
hal_btcoex_MediaStatusNotify(padapter, media_status);
}
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: rtl8723bs: simplify condition in rtw_btcoex_MediaStatusNotify
2026-03-19 7:40 [PATCH] staging: rtl8723bs: simplify condition in rtw_btcoex_MediaStatusNotify Zile Xiong
@ 2026-03-19 7:54 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-03-19 7:54 UTC (permalink / raw)
To: Zile Xiong; +Cc: linux-staging, linux-kernel, karanja99erick
On Thu, Mar 19, 2026 at 03:40:07PM +0800, Zile Xiong wrote:
> Remove redundant parentheses and unnecessary comparison to true
> in the conditional expression to improve readability.
>
> No functional change.
>
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> index f4b19ef7b341..b19eab0afba3 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
> @@ -10,10 +10,8 @@
>
> void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
> {
> - if ((media_status == RT_MEDIA_CONNECT)
> - && (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
> + if (media_status == RT_MEDIA_CONNECT && check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE))
Please no, now you need to remember that == takes precidence over &&.
> rtw_hal_set_hwreg(padapter, HW_VAR_DL_RSVD_PAGE, NULL);
> - }
You also did two different things here in the same change, which isn't
alowed for staging patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-19 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 7:40 [PATCH] staging: rtl8723bs: simplify condition in rtw_btcoex_MediaStatusNotify Zile Xiong
2026-03-19 7:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox