From: Greg KH <gregkh@linuxfoundation.org>
To: Omer El Idrissi <omer.e.idrissi@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH] staging: rtl8723bs: change error handling to use standard errno
Date: Fri, 20 Mar 2026 08:35:55 +0100 [thread overview]
Message-ID: <2026032020-captivity-overlying-adde@gregkh> (raw)
In-Reply-To: <20260320072951.54045-1-omer.e.idrissi@gmail.com>
On Fri, Mar 20, 2026 at 08:29:50AM +0100, Omer El Idrissi wrote:
> Replace non-standard return values with descriptive
> linux kernel error codes in probe path.
> Also replace the variable name 'status' with 'ret'
> to be more consistent with other kernel code
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 +++++++++++++-------
> 1 file changed, 19 insertions(+), 11 deletions(-)
Your suject line is a bit odd, why two [PATCH] strings?
Also, you can use the full 72 columns in the changelog body.
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-20 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 7:29 [PATCH] [PATCH] staging: rtl8723bs: change error handling to use standard errno Omer El Idrissi
2026-03-20 7:35 ` Greg KH [this message]
2026-03-20 7:36 ` Greg KH
[not found] ` <CACx49NfzUuHWdvME+850gJXLL==6x8Yw3_0yzZgJmAk089a7Aw@mail.gmail.com>
2026-03-20 8:47 ` Omer
2026-03-20 9:48 ` [PATCH v2] " Omer El Idrissi
2026-03-21 7:03 ` Greg KH
2026-03-21 20:17 ` Omer El Idrissi
2026-03-21 21:24 ` Dan Carpenter
2026-03-21 21:34 ` Omer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032020-captivity-overlying-adde@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=omer.e.idrissi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox