From: Gabriel Rondon <grondon@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org
Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] staging: iio: ad9834: use sysfs_emit() and simplify show functions
Date: Fri, 20 Mar 2026 22:24:24 +0000 [thread overview]
Message-ID: <20260320222424.53294-4-grondon@gmail.com> (raw)
In-Reply-To: <20260320222424.53294-1-grondon@gmail.com>
Replace sprintf() with sysfs_emit() in sysfs attribute show functions.
sysfs_emit() is the preferred API for sysfs callbacks as it is aware
of the PAGE_SIZE buffer limit.
Also simplify the wavetype_available show functions by removing
the intermediate string variable and returning directly from each
branch.
Signed-off-by: Gabriel Rondon <grondon@gmail.com>
---
drivers/staging/iio/frequency/ad9834.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index d339d5e8e..bdb2580e2 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -281,16 +281,12 @@ ssize_t ad9834_show_out0_wavetype_available(struct device *dev,
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ad9834_state *st = iio_priv(indio_dev);
- char *str;
if (st->devid == ID_AD9833 || st->devid == ID_AD9837)
- str = "sine triangle square";
- else if (st->control & AD9834_OPBITEN)
- str = "sine";
- else
- str = "sine triangle";
-
- return sprintf(buf, "%s\n", str);
+ return sysfs_emit(buf, "sine triangle square\n");
+ if (st->control & AD9834_OPBITEN)
+ return sysfs_emit(buf, "sine\n");
+ return sysfs_emit(buf, "sine triangle\n");
}
static IIO_DEVICE_ATTR(out_altvoltage0_out0_wavetype_available, 0444,
@@ -303,14 +299,10 @@ ssize_t ad9834_show_out1_wavetype_available(struct device *dev,
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ad9834_state *st = iio_priv(indio_dev);
- char *str;
if (st->control & AD9834_MODE)
- str = "";
- else
- str = "square";
-
- return sprintf(buf, "%s\n", str);
+ return sysfs_emit(buf, "\n");
+ return sysfs_emit(buf, "square\n");
}
static IIO_DEVICE_ATTR(out_altvoltage0_out1_wavetype_available, 0444,
--
2.33.0
next prev parent reply other threads:[~2026-03-20 22:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:57 [PATCH 0/3] staging: iio: replace sprintf() with sysfs_emit() Gabriel Rondon
2026-03-19 22:57 ` [PATCH 1/3] staging: iio: ad7816: use sysfs_emit() in show functions Gabriel Rondon
2026-03-19 22:57 ` [PATCH 2/3] staging: iio: ad5933: " Gabriel Rondon
2026-03-20 8:11 ` Andy Shevchenko
2026-03-21 16:53 ` Gabriel Rondon
2026-03-23 10:17 ` Andy Shevchenko
2026-03-19 22:57 ` [PATCH 3/3] staging: iio: ad9834: " Gabriel Rondon
2026-03-20 8:15 ` Andy Shevchenko
2026-03-21 13:15 ` Jonathan Cameron
2026-03-20 22:24 ` [PATCH v2 0/3] staging: iio: replace sprintf() with sysfs_emit() Gabriel Rondon
2026-03-20 22:24 ` [PATCH v2 1/3] staging: iio: ad7816: use sysfs_emit() in show functions Gabriel Rondon
2026-03-21 13:09 ` Jonathan Cameron
2026-03-20 22:24 ` [PATCH v2 2/3] staging: iio: ad5933: " Gabriel Rondon
2026-03-21 13:14 ` Jonathan Cameron
2026-03-20 22:24 ` Gabriel Rondon [this message]
2026-03-21 13:16 ` [PATCH v2 3/3] staging: iio: ad9834: use sysfs_emit() and simplify " Jonathan Cameron
2026-03-21 13:03 ` [PATCH v2 0/3] staging: iio: replace sprintf() with sysfs_emit() Jonathan Cameron
2026-03-21 15:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320222424.53294-4-grondon@gmail.com \
--to=grondon@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox