From: Jonathan Cameron <jic23@kernel.org>
To: Gabriel Rondon <grondon@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
gregkh@linuxfoundation.org, andriy.shevchenko@intel.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: iio: ad9834: use sysfs_emit() and simplify show functions
Date: Sat, 21 Mar 2026 13:16:52 +0000 [thread overview]
Message-ID: <20260321131652.2f25dec0@jic23-huawei> (raw)
In-Reply-To: <20260320222424.53294-4-grondon@gmail.com>
On Fri, 20 Mar 2026 22:24:24 +0000
Gabriel Rondon <grondon@gmail.com> wrote:
> Replace sprintf() with sysfs_emit() in sysfs attribute show functions.
> sysfs_emit() is the preferred API for sysfs callbacks as it is aware
> of the PAGE_SIZE buffer limit.
>
> Also simplify the wavetype_available show functions by removing
> the intermediate string variable and returning directly from each
> branch.
>
> Signed-off-by: Gabriel Rondon <grondon@gmail.com>
Similar to patch 2, I suspect this code will go through a lot of changes
if anyone does the work to move this driver out of staging.
So I'm applying this mostly to avoid anyone else sending patches
to do the same!
Applied.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-03-21 13:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 22:57 [PATCH 0/3] staging: iio: replace sprintf() with sysfs_emit() Gabriel Rondon
2026-03-19 22:57 ` [PATCH 1/3] staging: iio: ad7816: use sysfs_emit() in show functions Gabriel Rondon
2026-03-19 22:57 ` [PATCH 2/3] staging: iio: ad5933: " Gabriel Rondon
2026-03-20 8:11 ` Andy Shevchenko
2026-03-21 16:53 ` Gabriel Rondon
2026-03-23 10:17 ` Andy Shevchenko
2026-03-19 22:57 ` [PATCH 3/3] staging: iio: ad9834: " Gabriel Rondon
2026-03-20 8:15 ` Andy Shevchenko
2026-03-21 13:15 ` Jonathan Cameron
2026-03-20 22:24 ` [PATCH v2 0/3] staging: iio: replace sprintf() with sysfs_emit() Gabriel Rondon
2026-03-20 22:24 ` [PATCH v2 1/3] staging: iio: ad7816: use sysfs_emit() in show functions Gabriel Rondon
2026-03-21 13:09 ` Jonathan Cameron
2026-03-20 22:24 ` [PATCH v2 2/3] staging: iio: ad5933: " Gabriel Rondon
2026-03-21 13:14 ` Jonathan Cameron
2026-03-20 22:24 ` [PATCH v2 3/3] staging: iio: ad9834: use sysfs_emit() and simplify " Gabriel Rondon
2026-03-21 13:16 ` Jonathan Cameron [this message]
2026-03-21 13:03 ` [PATCH v2 0/3] staging: iio: replace sprintf() with sysfs_emit() Jonathan Cameron
2026-03-21 15:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321131652.2f25dec0@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=grondon@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox