From: Sajal Gupta <sajal2005gupta@gmail.com>
To: gregkh@linuxfoundation.org, s9430939@naver.com
Cc: andriy.shevchenko@intel.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, sajal2005gupta@gmail.com
Subject: [PATCH v2] staging: rtl8723bs: fix logical continuations in xmit_linux.c
Date: Tue, 24 Mar 2026 17:47:47 +0530 [thread overview]
Message-ID: <20260324121828.14675-1-sajal2005gupta@gmail.com> (raw)
Simplify the conditional by removing redundant boolean
comparisons and fixing the continuation line indentation.
Signed-off-by: Sajal Gupta <sajal2005gupta@gmail.com>
---
Changes in v2:
- compact the condition
- drop == true and == 0 checks
- fix tab alignment
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
index 0be3143fffe5..dc0b77f38b1a 100644
--- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
@@ -193,12 +193,9 @@ void _rtw_xmit_entry(struct sk_buff *pkt, struct net_device *pnetdev)
rtw_check_xmit_resource(padapter, pkt);
- if (!rtw_mc2u_disable
- && check_fwstate(pmlmepriv, WIFI_AP_STATE) == true
- && (IP_MCAST_MAC(pkt->data)
- || ICMPV6_MCAST_MAC(pkt->data)
- )
- && padapter->registrypriv.wifi_spec == 0) {
+ if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) &&
+ (IP_MCAST_MAC(pkt->data) || ICMPV6_MCAST_MAC(pkt->data)) &&
+ !padapter->registrypriv.wifi_spec) {
if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME / 4)) {
res = rtw_mlcst2unicst(padapter, pkt);
if (res)
--
2.53.0
next reply other threads:[~2026-03-24 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:17 Sajal Gupta [this message]
2026-03-24 12:44 ` [PATCH v2] staging: rtl8723bs: fix logical continuations in xmit_linux.c Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324121828.14675-1-sajal2005gupta@gmail.com \
--to=sajal2005gupta@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox