[PATCH 1/2] staging: rtl8723bs: Remove unneeded blank lines

[PATCH 1/2] staging: rtl8723bs: Remove unneeded blank lines

[Romy Rianata]

Remove multiple consecutive blank lines that serve no purpose.
This is a cosmetic cleanup to improve code readability.

No functional change.

Signed-off-by: Romy Rianata <arokigaming@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 50370b14c..279bc87c3 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -30,7 +30,6 @@ void rtw_hal_data_deinit(struct adapter *padapter)
 	}
 }
 
-
 void dump_chip_info(struct hal_version	ChipVersion)
 {
 	char buf[128];
@@ -71,7 +70,6 @@ void dump_chip_info(struct hal_version	ChipVersion)
 	cnt += scnprintf(buf + cnt, sizeof(buf) - cnt, "RomVer(%d)\n", ChipVersion.ROMVer);
 }
 
-
 #define	EEPROM_CHANNEL_PLAN_BY_HW_MASK	0x80
 
 /*
@@ -292,7 +290,6 @@ u8 HwRateToMRate(u8 rate)
 void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
 {
 	u8 i, is_brate, brate;
-
 	for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
 
 		is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
-- 
2.53.0

[PATCH 2/2] staging: rtl8723bs: Fix comparison orientation

[Romy Rianata]

Move constant value to the right side of the comparison operator.
This follows the kernel coding style convention.

No functional change.

Signed-off-by: Romy Rianata <arokigaming@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 279bc87c3..69538246b 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -105,7 +105,7 @@ u8 hal_com_config_channel_plan(
 	pHalData->bDisableSWChannelPlan = false;
 	chnlPlan = def_channel_plan;
 
-	if (0xFF == hw_channel_plan)
+	if (hw_channel_plan == 0xFF)
 		AutoLoadFail = true;
 
 	if (!AutoLoadFail) {
-- 
2.53.0

Re: [PATCH 1/2] staging: rtl8723bs: Remove unneeded blank lines

[Dan Carpenter]

On Fri, Mar 27, 2026 at 08:22:11AM +0800, Romy Rianata wrote:
> @@ -292,7 +290,6 @@ u8 HwRateToMRate(u8 rate)
>  void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
>  {
>  	u8 i, is_brate, brate;
> -
>  	for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
>  
>  		is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;

Looks like you accidentally deleted the wrong blank line.

regards,
dan carpenter