[PATCH] staging: greybus: remove unused conn argument from loopback macro

[PATCH] staging: greybus: remove unused conn argument from loopback macro

[Hungyu Lin]

The 'conn' argument in the gb_dev_loopback_ro_attr macro is not
used in the macro body. Remove it to clean up the code and fix
the checkpatch warning.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/greybus/loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index aa9c73cb0..34e79e99c 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -193,7 +193,7 @@ static ssize_t field##_store(struct device *dev,			\
 }									\
 static DEVICE_ATTR_RW(field)
 
-#define gb_dev_loopback_ro_attr(field, conn)				\
+#define gb_dev_loopback_ro_attr(field)				\
 static ssize_t field##_show(struct device *dev,		\
 			    struct device_attribute *attr,		\
 			    char *buf)					\
-- 
2.34.1

Re: [PATCH] staging: greybus: remove unused conn argument from loopback macro

[Greg Kroah-Hartman]

On Thu, Mar 19, 2026 at 01:20:08AM +0000, Hungyu Lin wrote:
> The 'conn' argument in the gb_dev_loopback_ro_attr macro is not
> used in the macro body. Remove it to clean up the code and fix
> the checkpatch warning.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/staging/greybus/loopback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index aa9c73cb0..34e79e99c 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -193,7 +193,7 @@ static ssize_t field##_store(struct device *dev,			\
>  }									\
>  static DEVICE_ATTR_RW(field)
>  
> -#define gb_dev_loopback_ro_attr(field, conn)				\
> +#define gb_dev_loopback_ro_attr(field)				\
>  static ssize_t field##_show(struct device *dev,		\
>  			    struct device_attribute *attr,		\
>  			    char *buf)					\
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did not apply to any known trees that Greg is in control
  of.  Possibly this is because you made it against Linus's tree, not
  the linux-next tree, which is where all of the development for the
  next version of the kernel is at.  Please refresh your patch against
  the linux-next tree, or even better yet, the development tree
  specified in the MAINTAINERS file for the subsystem you are submitting
  a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot