[PATCH v4 0/4] staging: media: atomisp: Few coding style fixes

[PATCH v4 0/4] staging: media: atomisp: Few coding style fixes

[Serban-Pascu Robert]

Changes since v3:
- Added a descriptive subject to the cover letter,
- as requested by Daniel Baluta.

Serban-Pascu Robert (4):
  staging: media: atomisp: fix SPDX license identifier style
  staging: media: atomisp: fix typo 'uninterruptible' in comment
  staging: media: atomisp: reformat block comments
  staging: media: atomisp: remove redundant blank lines

 drivers/staging/media/atomisp/pci/system_global.h | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

-- 
2.43.0

[PATCH v4 1/4] staging: media: atomisp: fix SPDX license identifier style

[Serban-Pascu Robert]

Use the C-style block comment for the SPDX license identifier in the
header file as per Linux kernel coding standards.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index e8a29f73d67a..c99fb649fb5f 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -1,5 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-// SPDX-License-Identifier: GPL-2.0-or-later
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  *    (c) 2020 Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  */
-- 
2.43.0

Re: [PATCH v4 1/4] staging: media: atomisp: fix SPDX license identifier style

[Andy Shevchenko]

On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Use the C-style block comment for the SPDX license identifier in the
> header file as per Linux kernel coding standards.

I am not sure about this. I believe this should be considered with an
additional thought. The thing is, AFAIU, that the header is a
combination of a few from original driver code where they have
different licensing. If Sakari thinks this is okay, the change is
good.

...

> --- a/drivers/staging/media/atomisp/pci/system_global.h
> +++ b/drivers/staging/media/atomisp/pci/system_global.h
> @@ -1,5 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -// SPDX-License-Identifier: GPL-2.0-or-later
> +/* SPDX-License-Identifier: GPL-2.0-or-later */


-- 
With Best Regards,
Andy Shevchenko

[PATCH v4 2/4] staging: media: atomisp:

[Serban-Pascu Robert]

Correct a spelling error in a comment: 
'uninteruptible' -> 'uninterruptible'.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index c99fb649fb5f..6420436d88f7 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -28,7 +28,7 @@
 #define DMA_DDR_TO_HMEM_WORKAROUND
 
 /*
- * The longest allowed (uninteruptible) bus transfer, does not
+ * The longest allowed (uninterruptible) bus transfer, does not
  * take stalling into account
  */
 #define HIVE_ISP_MAX_BURST_LENGTH	1024
-- 
2.43.0

Re: [PATCH v4 2/4] staging: media: atomisp:

[Andy Shevchenko]

On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Correct a spelling error in a comment:
> 'uninteruptible' -> 'uninterruptible'.

...

>  /*
> - * The longest allowed (uninteruptible) bus transfer, does not
> + * The longest allowed (uninterruptible) bus transfer, does not
>   * take stalling into account

While at it, you can also add a missing period at the end.

>   */
>  #define HIVE_ISP_MAX_BURST_LENGTH      1024


-- 
With Best Regards,
Andy Shevchenko

[PATCH v4 3/4] staging: media: atomisp: reformat block comments

[Serban-Pascu Robert]

Add missing asterisks to block comments to conform with the
standard Linux kernel comment style.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index 6420436d88f7..c65a5be8445a 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -100,8 +100,9 @@ typedef enum {
 	N_GDC_ID
 } gdc_ID_t;
 
-/* this extra define is needed because we want to use it also
-   in the preprocessor, and that doesn't work with enums.
+/*
+ * this extra define is needed because we want to use it also
+ * in the preprocessor, and that doesn't work with enums.
  */
 #define N_GDC_ID_CPP 2
 
-- 
2.43.0

Re: [PATCH v4 3/4] staging: media: atomisp: reformat block comments

[Andy Shevchenko]

On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Add missing asterisks to block comments to conform with the
> standard Linux kernel comment style.

I don't believe it's the only problem like this in the entire driver.
Fix more of them if not all.

...

> -/* this extra define is needed because we want to use it also
> -   in the preprocessor, and that doesn't work with enums.
> +/*
> + * this extra define is needed because we want to use it also
> + * in the preprocessor, and that doesn't work with enums.

You should also respect English grammar:
this --> This
define --> #define

>   */
>  #define N_GDC_ID_CPP 2

-- 
With Best Regards,
Andy Shevchenko

[PATCH v4 4/4] staging: media: atomisp: remove redundant blank lines

[Serban-Pascu Robert]

Remove multiple consecutive blank lines to improve code readability
and follow kernel style guidelines.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index c65a5be8445a..d417230faff2 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -218,7 +218,6 @@ typedef enum {
 #define	N_ACQUISITION_UNIT_ID		1
 #define	N_CTRL_UNIT_ID			1
 
-
 enum ia_css_isp_memories {
 	IA_CSS_ISP_PMEM0 = 0,
 	IA_CSS_ISP_DMEM0,
@@ -248,7 +247,6 @@ typedef enum {
 	N_ISYS_IRQ_ID
 } isys_irq_ID_t;
 
-
 /*
  * Input-buffer Controller.
  */
-- 
2.43.0

Re: [PATCH v4 4/4] staging: media: atomisp: remove redundant blank lines

[Andy Shevchenko]

On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Remove multiple consecutive blank lines to improve code readability
> and follow kernel style guidelines.

Unneeded churn for now. This driver has many more issues that need to
be fixed first.


-- 
With Best Regards,
Andy Shevchenko