public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: luka.gejak@linux.dev
To: Andrei Khomenkov <khomenkov@mailbox.org>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
	luka.gejak@linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: clean up booleans and parentheses
Date: Mon, 30 Mar 2026 09:50:10 +0200	[thread overview]
Message-ID: <20260330075010.62498-1-luka.gejak@linux.dev> (raw)
In-Reply-To: <20260325110143.35466-1-khomenkov@mailbox.org>

Thanks for working on cleaning up this driver. The approach is correct,
but the patch is incomplete - several instances of the same patterns
were missed, creating inconsistent style within the same functions.
Please run the following to find all remaining instances in the files
you're touching:

  git grep -n -E '== (true|false)' drivers/staging/rtl8723bs/

Also consider splitting this into a patch series:
  - Patch 1: boolean comparison cleanups
  - Patch 2: unnecessary parentheses removal
This makes review easier and bisection more straightforward if issues
arise. The semantic changes themselves look correct - no issues are 
introducedby the transformations you did make.
Please send v2 with mentioned changes.
Best regards,
Luka Gejak

      reply	other threads:[~2026-03-30  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 11:01 [PATCH] staging: rtl8723bs: clean up booleans and parentheses Andrei Khomenkov
2026-03-30  7:50 ` luka.gejak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260330075010.62498-1-luka.gejak@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=khomenkov@mailbox.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox