Re: [PATCH 0/2] staging: rtl8723bs: fix boolean logic and clean up coding style

[luka.gejak@linux.dev]

Thanks for working on this cleanup. The series is well-structured and
almost perfect, however below is my comment on what could be improved.

PATCH 1/2
Looks good, the defensive fix is correct and the commit message explains
the rationale well, but:
The subject lines use 'core:rtw_wlan_util.c' which is non-standard.
The kernel convention for staging patches is:
  [PATCH <n/m>] staging: <driver-name>: <short description>
Patch 1/2:
  [PATCH 1/2] staging: rtl8723bs: fix boolean comparison Switch_DM_Func

PATCH 2/2
Two issues to address:
1) In adaptive_early_32k(), you left this unchanged:
   if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done == true))
   This should be converted to match the boolean fix in patch 1:
   if (pmlmeext->bcn_cnt > 100 && pmlmeext->adaptive_tsf_done)
2) Patch 2 does not apply to staging-next tree, please rebase on top of
   a staging-next and resend

Also one more thing, please make proper indentation, if you are line 
breaking you should allign ( and ( from line above. Same for letters 
you should allign the first letter in bracket with the first letter 
from upper line. Your code: 

-				rtw_hal_set_hwreg(Adapter, HW_VAR_ACK_PREAMBLE, (u8 *)&ShortPreamble);
+				rtw_hal_set_hwreg(Adapter, HW_VAR_ACK_PREAMBLE,
+						  (u8 *)&ShortPreamble);

-			pmlmeext->bcn_delay_ratio[i] = (pmlmeext->bcn_delay_cnt[i] * 100) / pmlmeext->bcn_cnt;
+			pmlmeext->bcn_delay_ratio[i] = (pmlmeext->bcn_delay_cnt[i] * 100) /
+				pmlmeext->bcn_cnt;

Correct:
-                               rtw_hal_set_hwreg(Adapter, HW_VAR_ACK_PREAMBLE, (u8 *)&ShortPreamble);
+                               rtw_hal_set_hwreg(Adapter, HW_VAR_ACK_PREAMBLE,
+                                                (u8 *)&ShortPreamble);

-                       pmlmeext->bcn_delay_ratio[i] = (pmlmeext->bcn_delay_cnt[i] * 100) / pmlmeext->bcn_cnt;
+                       pmlmeext->bcn_delay_ratio[i] = (pmlmeext->bcn_delay_cnt[i] * 100) /
+                                 			pmlmeext->bcn_cnt;

Best regards,
Luka Gejak