From: Mashiro Chen <mashiro.chen@mailbox.org>
To: gregkh@linuxfoundation.org
Cc: error27@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Mashiro Chen <mashiro.chen@mailbox.org>
Subject: [PATCH v2 1/3] staging: rtl8723bs: remove unused WRITEEF/READEF byte macros
Date: Mon, 30 Mar 2026 19:42:30 +0800 [thread overview]
Message-ID: <20260330114232.91431-2-mashiro.chen@mailbox.org> (raw)
In-Reply-To: <20260330114232.91431-1-mashiro.chen@mailbox.org>
The WRITEEF4BYTE, WRITEEF2BYTE, WRITEEF1BYTE, READEF4BYTE,
READEF2BYTE and READEF1BYTE macros are never used in the driver.
Remove them entirely.
Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
---
.../staging/rtl8723bs/include/basic_types.h | 25 -------------------
1 file changed, 25 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
index 8adb95f9f1e5..69f7402d8e5c 100644
--- a/drivers/staging/rtl8723bs/include/basic_types.h
+++ b/drivers/staging/rtl8723bs/include/basic_types.h
@@ -42,31 +42,6 @@
#define EF4BYTE(_val) \
(le32_to_cpu(_val))
-/* Read data from memory */
-#define READEF1BYTE(_ptr) \
- EF1BYTE(*((u8 *)(_ptr)))
-/* Read le16 data from memory and convert to host ordering */
-#define READEF2BYTE(_ptr) \
- EF2BYTE(*(_ptr))
-#define READEF4BYTE(_ptr) \
- EF4BYTE(*(_ptr))
-
-/* Write data to memory */
-#define WRITEEF1BYTE(_ptr, _val) \
- do { \
- (*((u8 *)(_ptr))) = EF1BYTE(_val); \
- } while (0)
-/* Write le data to memory in host ordering */
-#define WRITEEF2BYTE(_ptr, _val) \
- do { \
- (*((u16 *)(_ptr))) = EF2BYTE(_val); \
- } while (0)
-
-#define WRITEEF4BYTE(_ptr, _val) \
- do { \
- (*((u32 *)(_ptr))) = EF2BYTE(_val); \
- } while (0)
-
/*
* Create a bit mask
* Examples:
--
2.53.0
next prev parent reply other threads:[~2026-03-30 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 11:42 [PATCH v2 0/3] staging: rtl8723bs: macro fixes in basic_types.h Mashiro Chen
2026-03-30 11:42 ` Mashiro Chen [this message]
2026-03-30 11:42 ` [PATCH v2 2/3] staging: rtl8723bs: wrap complex macros with parentheses Mashiro Chen
2026-03-30 11:42 ` [PATCH v2 3/3] staging: rtl8723bs: remove redundant blank lines in basic_types.h Mashiro Chen
2026-03-30 14:36 ` [PATCH v2 0/3] staging: rtl8723bs: macro fixes " Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330114232.91431-2-mashiro.chen@mailbox.org \
--to=mashiro.chen@mailbox.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox