* [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
@ 2026-03-29 11:23 Tanjim Kamal
2026-03-30 15:59 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Tanjim Kamal @ 2026-03-29 11:23 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Oskar Ray-Frayssinet, Ethan Tidmore, linux-staging, linux-kernel,
Tanjim Kamal
The line was misaligned. Align the arguments with the parenthesis above
and wrap the line to prevent crossing the 100-character limit.
Fix a CHECK issued by scripts/checkpatch.pl.
Signed-off-by: Tanjim Kamal <tanjimkamal1@gmail.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870..1c34de020 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+ ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
+ words_to_write);
if (ret)
goto end_unlock;
}
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
2026-03-29 11:23 [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible() Tanjim Kamal
@ 2026-03-30 15:59 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-03-30 15:59 UTC (permalink / raw)
To: Tanjim Kamal
Cc: Oskar Ray-Frayssinet, Ethan Tidmore, linux-staging, linux-kernel
On Sun, Mar 29, 2026 at 05:23:52PM +0600, Tanjim Kamal wrote:
> The line was misaligned. Align the arguments with the parenthesis above
> and wrap the line to prevent crossing the 100-character limit.
>
> Fix a CHECK issued by scripts/checkpatch.pl.
>
> Signed-off-by: Tanjim Kamal <tanjimkamal1@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870..1c34de020 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> + words_to_write);
> if (ret)
> goto end_unlock;
> }
> --
> 2.47.3
>
No, the original code is fine here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-30 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-29 11:23 [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible() Tanjim Kamal
2026-03-30 15:59 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox