From: "Md. Mahmudul Hasan Mabud" <mdmahmudulhasan1511@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Md. Mahmudul Hasan Mabud" <mdmahmudulhasan1511@gmail.com>
Subject: [PATCH v2 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection
Date: Mon, 30 Mar 2026 23:40:22 +0600 [thread overview]
Message-ID: <20260330174024.20712-3-mdmahmudulhasan1511@gmail.com> (raw)
In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com>
---
drivers/staging/iio/adc/ad7816.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 5acfceb90..f9a0a5a69 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -58,6 +58,11 @@ enum ad7816_type {
ID_AD7818,
};
+static const char * const ad7816_modes[] = {
+ [AD7816_FULL] = "full",
+ [AD7816_PD] = "power-save",
+};
+
/*
* ad7816 data access by SPI
*/
@@ -135,14 +140,14 @@ static ssize_t ad7816_store_mode(struct device *dev,
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ad7816_chip_info *chip = iio_priv(indio_dev);
+ int ret;
- if (strcmp(buf, "full") == 0) {
- gpiod_set_value(chip->rdwr_pin, 1);
- chip->mode = AD7816_FULL;
- } else {
- gpiod_set_value(chip->rdwr_pin, 0);
- chip->mode = AD7816_PD;
- }
+ ret = sysfs_match_string(ad7816_modes, buf);
+ if (ret < 0)
+ return ret;
+
+ chip->mode = ret;
+ gpiod_set_value(chip->rdwr_pin, ret == AD7816_FULL);
return len;
}
--
2.34.1
next prev parent reply other threads:[~2026-03-30 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 17:40 [PATCH v2 0/4] staging: iio: adc: ad7816: code cleanups and modernization Md. Mahmudul Hasan Mabud
2026-03-30 17:40 ` [PATCH v2 1/4] staging: iio: adc: ad7816: redefine mode constants to start from 0 Md. Mahmudul Hasan Mabud
2026-03-30 17:48 ` Greg Kroah-Hartman
2026-03-30 17:40 ` Md. Mahmudul Hasan Mabud [this message]
2026-03-30 17:40 ` [PATCH v2 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Md. Mahmudul Hasan Mabud
2026-03-30 17:40 ` [PATCH v2 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Md. Mahmudul Hasan Mabud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330174024.20712-3-mdmahmudulhasan1511@gmail.com \
--to=mdmahmudulhasan1511@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox