public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Bera Yüzlü" <b9788213@gmail.com>
Cc: filippo.muschera@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: refactor switch-case
Date: Mon, 30 Mar 2026 18:01:53 +0200	[thread overview]
Message-ID: <2026033037-dust-stardom-08da@gregkh> (raw)
In-Reply-To: <20260328163357.163332-2-b9788213@gmail.com>

On Sat, Mar 28, 2026 at 07:33:58PM +0300, Bera Yüzlü wrote:
> Refactored huge switch-case to lookup table. Used if-else for dynamic
> values.

That says what you did, but not why?

And did you test this?

And why do this at all?

thanks,

greg k-h

      parent reply	other threads:[~2026-03-30 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 16:33 [PATCH] staging: rtl8723bs: refactor switch-case Bera Yüzlü
2026-03-30  9:35 ` Dan Carpenter
2026-03-30 16:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026033037-dust-stardom-08da@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=b9788213@gmail.com \
    --cc=filippo.muschera@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox