Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag()

Dan Carpenter
2026-03-31T19:40:06Z

On Tue, Mar 31, 2026 at 05:44:29PM +0100, grondon@gmail.com wrote:
> From: Gabriel Rondon <grondon@gmail.com>
>
> On Tue, 31 Mar 2026 13:55:43 +0300, Dan Carpenter wrote:
> > hdm_ch can't be NULL. It's a pointer to the middle of a struct plus
> > an offset.
>
> You're right, the NULL check is unnecessary here. Will send a fix
> removing the !hdm_ch check and keeping only !hdm_ch->is_initialized.

Check them all, right? Maybe the others are similar?

regards,
dan carpenter