From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Probert <linus.probert@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: rename global functions
Date: Tue, 31 Mar 2026 10:43:26 +0200 [thread overview]
Message-ID: <2026033148-mortuary-giveaway-43aa@gregkh> (raw)
In-Reply-To: <20260331053843.108678-2-linus.probert@gmail.com>
On Tue, Mar 31, 2026 at 07:38:42AM +0200, Linus Probert wrote:
> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
> @@ -31,7 +31,7 @@ enum {
> #define EFUSE_REPEAT_THRESHOLD_ 3
>
> /* */
> -/* The following is for BT Efuse definition */
> +/* The following is for BT Efuse definition */
> /* */
> #define EFUSE_BT_MAX_MAP_LEN 1024
> #define EFUSE_MAX_BANK 4
Why make this coding style change when you are just renaming functions?
And how about one-patch-per-function being renamed? Make this a patch
series?
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-31 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 5:38 [PATCH v2 0/2] rename and remove functions Linus Probert
2026-03-31 5:38 ` [PATCH v2 1/2] staging: rtl8723bs: rename global functions Linus Probert
2026-03-31 8:43 ` Greg Kroah-Hartman [this message]
2026-03-31 5:38 ` [PATCH v2 2/2] staging: rtl8723bs: remove unused functions Linus Probert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026033148-mortuary-giveaway-43aa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linus.probert@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox