[PATCH v3] staging: rtl8723bs: fix CamelCase warning for READ_MACREG

[PATCH v3] staging: rtl8723bs: fix CamelCase warning for READ_MACREG

[Xiyuan Guo]

Rename the _Read_MACREG macro to READ_MACREG to resolve the checkpatch.pl
"Avoid CamelCase" warning. This aligns the macro naming with the kernel
coding style guidelines.

Signed-off-by: Xiyuan Guo <tommyguo039@gmail.com>
---
Changes in v3:
  - Dropped unrelated whitespace modifications caught by maintainers.
  - Rebased onto staging-next.

 drivers/staging/rtl8723bs/core/rtw_cmd.c         | 2 +-
 drivers/staging/rtl8723bs/include/rtw_cmd.h      | 2 +-
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..eb902c810ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -11,7 +11,7 @@
 #include <linux/delay.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
+	{GEN_CMD_CODE(READ_MACREG), NULL}, /*0*/
 	{GEN_CMD_CODE(_Write_MACREG), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index c4c3edee809d..d204426799ef 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -630,7 +630,7 @@ struct _cmd_callback {
 };
 
 enum {
-	GEN_CMD_CODE(_Read_MACREG),	/*0*/
+	GEN_CMD_CODE(READ_MACREG),	/*0*/
 	GEN_CMD_CODE(_Write_MACREG),
 	GEN_CMD_CODE(_Read_BBREG),
 	GEN_CMD_CODE(_Write_BBREG),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 95769f90d196..d14cabd5e47c 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -679,7 +679,7 @@ void rtw_dummy_event_callback(struct adapter *adapter, u8 *pbuf);
 void rtw_fwdbg_event_callback(struct adapter *adapter, u8 *pbuf);
 
 enum {
-	GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
+	GEN_EVT_CODE(READ_MACREG) = 0, /*0*/
 	GEN_EVT_CODE(_Read_BBREG),
 	GEN_EVT_CODE(_Read_RFREG),
 	GEN_EVT_CODE(_Read_EEPROM),
-- 
2.53.0

Re: [PATCH v3] staging: rtl8723bs: fix CamelCase warning for READ_MACREG

[Greg KH]

On Tue, Mar 31, 2026 at 12:39:54AM -0400, Xiyuan Guo wrote:
> Rename the _Read_MACREG macro to READ_MACREG to resolve the checkpatch.pl
> "Avoid CamelCase" warning. This aligns the macro naming with the kernel
> coding style guidelines.
> 
> Signed-off-by: Xiyuan Guo <tommyguo039@gmail.com>
> ---
> Changes in v3:
>   - Dropped unrelated whitespace modifications caught by maintainers.
>   - Rebased onto staging-next.
> 
>  drivers/staging/rtl8723bs/core/rtw_cmd.c         | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_cmd.h      | 2 +-
>  drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index c1185c25ed36..eb902c810ac8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -11,7 +11,7 @@
>  #include <linux/delay.h>
>  
>  static struct _cmd_callback rtw_cmd_callback[] = {
> -	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
> +	{GEN_CMD_CODE(READ_MACREG), NULL}, /*0*/

Ok, but now what does the result look like?  You are creating a function
name called cmdREAD_MACREG(), is that intended?

That's why those leading '_' characters are there.

How about unwinding this mess of function pointers and #defines
entirely?  It's not needed and is just yet-another layer of indirection
in this driver that needs to be removed.

thanks,

greg k-h