Re: [PATCH 3/3] staging: octeon: ethernet: add pr_fmt macro

Greg KH
2026-03-24T14:28:47Z

On Tue, Mar 24, 2026 at 07:00:29PM +0530, AyushMukkanwar wrote:
> Add pr_fmt macro to prefix log messages with the module
> name for easier debugging.
>
> Signed-off-by: AyushMukkanwar <ayushmukkanwar@gmail.com>
> ---
> drivers/staging/octeon/ethernet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index eadb74fc14c8..5bb8c303f88b 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -5,6 +5,7 @@
> * Copyright (c) 2003-2007 Cavium Networks
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> #include <linux/platform_device.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> --
> 2.53.0
>

How about working to remove the existing pr_*() calls with the proper
dev_*() and netdev_*() calls instead, so that pr_fmt() is not needed at
all? That is the more "correct" solution here.

thanks,

greg k-h