From: grondon@gmail.com
To: error27@gmail.com
Cc: gregkh@linuxfoundation.org, christian.gromm@microchip.com,
parthiban.veerasooran@microchip.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Gabriel Rondon <grondon@gmail.com>
Subject: Re: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag()
Date: Wed, 1 Apr 2026 11:09:56 +0100 [thread overview]
Message-ID: <20260401100956.22590-1-grondon@gmail.com> (raw)
In-Reply-To: <acwjEHyEYg0V3OyC@stanley.mountain>
From: Gabriel Rondon <grondon@gmail.com>
On Tue, 31 Mar 2026 22:40:00 +0300, Dan Carpenter wrote:
> Check them all, right? Maybe the others are similar?
Checked. Patches 3/5 through 5/5 (configure_channel, enqueue,
poison_channel) only check ch_idx range, no hdm_ch NULL check — those
are fine.
Patch 1/5 (try_start_dim_transfer) does have the same unnecessary
!hdm_ch check. hdm_ch is a parameter there, but it's already
dereferenced on the line above (head = &hdm_ch->pending_list), so a
NULL check after that is dead code. Will send a fix for that one too.
Thanks,
Gabriel
next prev parent reply other threads:[~2026-04-01 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 18:22 [PATCH v2 0/5] staging: most: dim2: replace BUG_ON() with graceful error handling grondon
2026-03-30 18:22 ` [PATCH v2 1/5] staging: most: dim2: replace BUG_ON() in try_start_dim_transfer() grondon
2026-03-30 18:22 ` [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() grondon
2026-03-31 10:55 ` Dan Carpenter
2026-03-31 16:44 ` grondon
2026-03-31 19:40 ` Dan Carpenter
2026-04-01 10:09 ` grondon [this message]
2026-03-30 18:22 ` [PATCH v2 3/5] staging: most: dim2: replace BUG_ON() in configure_channel() grondon
2026-03-30 18:22 ` [PATCH v2 4/5] staging: most: dim2: replace BUG_ON() in enqueue() grondon
2026-03-30 18:22 ` [PATCH v2 5/5] staging: most: dim2: replace BUG_ON() in poison_channel() grondon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260401100956.22590-1-grondon@gmail.com \
--to=grondon@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox