public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Probert <linus.probert@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] rename/remove functions and code style cleanup
Date: Wed, 1 Apr 2026 12:05:59 +0200	[thread overview]
Message-ID: <2026040120-hangover-disarray-5981@gregkh> (raw)
In-Reply-To: <20260331155318.185117-1-linus.probert@gmail.com>

On Tue, Mar 31, 2026 at 05:53:11PM +0200, Linus Probert wrote:
> Thanks for the feedback on my last patch. I have adapted the following:
> 
> - Split each global function rename into their own patch. (1 - 5)
> - Placed the removed functions in their own patch. (6)
> - Created one additional patch for removal of a "space before tab"
>   warning. (7)
> 
> Br,
> Linus
> 
> Linus Probert (7):
>   staging: rtl8723bs: rename global function to snake_case
>   staging: rtl8723bs: rename global function to snake_case
>   staging: rtl8723bs: rename global function to snake_case
>   staging: rtl8723bs: rename global function to snake_case
>   staging: rtl8723bs: rename global function to snake_case

You have 5 different patches here with the same subject line, yet they
do different things.  Please make these unique, otherwise this looks
very odd, don't you think?

And the changelog is the hardest part of writing a patch, as you are
finding out :)

thanks,

greg k-h

      parent reply	other threads:[~2026-04-01 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 15:53 [PATCH v3 0/7] rename/remove functions and code style cleanup Linus Probert
2026-03-31 15:53 ` [PATCH v3 1/7] staging: rtl8723bs: rename global function to snake_case Linus Probert
2026-03-31 15:53 ` [PATCH v3 2/7] " Linus Probert
2026-03-31 15:53 ` [PATCH v3 3/7] " Linus Probert
2026-03-31 15:53 ` [PATCH v3 4/7] " Linus Probert
2026-03-31 15:53 ` [PATCH v3 5/7] " Linus Probert
2026-03-31 15:53 ` [PATCH v3 6/7] staging: rtl8723bs: remove unused global functions Linus Probert
2026-03-31 15:53 ` [PATCH v3 7/7] staging: rtl8723bs: remove space before tab Linus Probert
2026-04-01  1:39 ` [PATCH v3 0/7] rename/remove functions and code style cleanup Ethan Tidmore
2026-04-01 10:05 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026040120-hangover-disarray-5981@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linus.probert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox