From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: constify fix_id array
Date: Wed, 1 Apr 2026 12:09:47 +0200 [thread overview]
Message-ID: <2026040129-maverick-blandness-084d@gregkh> (raw)
In-Reply-To: <20260331135759.19108-1-dennylin0707@gmail.com>
On Tue, Mar 31, 2026 at 01:57:59PM +0000, Hungyu Lin wrote:
> Constify the static fix_id array so it can be placed in read-only memory.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
>
> ---
> Changes in v2:
> - Drop g_fbmode change as it is modified at runtime.
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 62f6e0cdf..795e9164b 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> "kernel HELPERS prepared vesa_modes",
> };
>
> - static const char *fix_id[2] = {
> + static const char * const fix_id[2] = {
> "sm750_fb1", "sm750_fb2",
> };
>
> --
> 2.34.1
>
>
This is really a "v3" patch, AND please don't respond within the middle
of the thread, make it a new one.
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-01 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 5:07 [PATCH] staging: sm750fb: constify static char pointer arrays Hungyu Lin
2026-03-31 8:45 ` Greg Kroah-Hartman
2026-03-31 13:30 ` Denny Lin
2026-03-31 13:37 ` [PATCH] staging: sm750fb: constify fix_id array Hungyu Lin
2026-03-31 13:43 ` [PATCH v2] " Hungyu Lin
2026-03-31 13:50 ` Greg Kroah-Hartman
2026-03-31 13:57 ` Hungyu Lin
2026-04-01 10:09 ` Greg Kroah-Hartman [this message]
2026-03-31 14:33 ` [PATCH] staging: sm750fb: constify static char pointer arrays kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026040129-maverick-blandness-084d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dennylin0707@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox