From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB8FE38B7CF;
	Wed,  1 Apr 2026 10:09:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775038189; cv=none; b=D+7IJ05rKXBSMiLf4PrbXOFjyfny9fHRzQM6iqB1MUJSIgG3PEA6APT0FCrlo/tKT8HJygcXLThiYXdLdMA1gjfrrlnpDmio/69TmSR+J26gbSzrmwrVu7/z7GzMKhwubKdYeBA98R1MIf7bRmXzypCmmGj3AgKgz0E/ERsekKk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775038189; c=relaxed/simple;
	bh=L11j2EbvngSXn5/Y97Dj59dx/uLWIIoZMFR5GnuStc0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=M7s9bJYr5KBJzO9qa86aRODVHMofQfSr3ZbwhV2b4XpdQK5vAjruII/H8Id7rBu9vrMtxq1jBJ2si0Lh9qEnR3nTX3Mt1FYCxSs5zQ9h+syVn/a3MuMlFqBKas/Tdk/uQwiBktN1D32/Cf9/mwf9nzuLfeWpOYba5MkDveLvQzg=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cMMG91VN; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cMMG91VN"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F9AEC4CEF7;
	Wed,  1 Apr 2026 10:09:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1775038189;
	bh=L11j2EbvngSXn5/Y97Dj59dx/uLWIIoZMFR5GnuStc0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=cMMG91VNPOV+5qFZ0F7FSq1I9LLKgZV08MDf/iwllsOpryEtFPJbMADU+tderf9ip
	 Mytl6EwLDTTtYsQuvcFjz6fvJJ2alvN2OicXcvNfA/YAgeTkGERgdL6s5qOrznkImh
	 DrsX9JNWB74F64A+XFPgVmATnbhTo8NElB4khCKg=
Date: Wed, 1 Apr 2026 12:09:47 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: constify fix_id array
Message-ID: <2026040129-maverick-blandness-084d@gregkh>
References: <20260331050738.1547-1-dennylin0707@gmail.com>
 <20260331135759.19108-1-dennylin0707@gmail.com>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260331135759.19108-1-dennylin0707@gmail.com>

On Tue, Mar 31, 2026 at 01:57:59PM +0000, Hungyu Lin wrote:
> Constify the static fix_id array so it can be placed in read-only memory.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> 
> ---
> Changes in v2:
> - Drop g_fbmode change as it is modified at runtime.
> ---
>  drivers/staging/sm750fb/sm750.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 62f6e0cdf..795e9164b 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
>  		"kernel HELPERS prepared vesa_modes",
>  	};
>  
> -	static const char *fix_id[2] = {
> +	static const char * const fix_id[2] = {
>  		"sm750_fb1", "sm750_fb2",
>  	};
>  
> -- 
> 2.34.1
> 
> 

This is really a "v3" patch, AND please don't respond within the middle
of the thread, make it a new one.

thanks,

greg k-h