public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Mukkanwar <ayushmukkanwar@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] staging: octeon: replace pr_* with dev_* and netdev_*
Date: Thu, 2 Apr 2026 13:50:48 +0200	[thread overview]
Message-ID: <2026040207-shank-urethane-3014@gregkh> (raw)
In-Reply-To: <20260402114242.57411-1-ayushmukkanwar@gmail.com>

On Thu, Apr 02, 2026 at 05:12:40PM +0530, Ayush Mukkanwar wrote:
> This series replaces pr_*() logging calls with dev_*() and netdev_*()
> in the octeon ethernet staging driver to include device context in
> log messages, as requested by Greg Kroah-Hartman.
> Changes since v2:
> - Use netdev_err() instead of dev_err() in ethernet-spi.c
> - Pass the netdev pointer directly to request_irq/free_irq
>   instead of dev->dev.parent
> - Move the device pointer to be the first argument in helper
>   functions

I don't see this happening, and I see other comments that I made were
not followed :(

Please, take some time, break this up into much smaller pieces, and
re-read my previous review comments and apply them everywhere.

thanks,

greg k-h

  parent reply	other threads:[~2026-04-02 11:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 11:42 [PATCH v3 0/2] staging: octeon: replace pr_* with dev_* and netdev_* Ayush Mukkanwar
2026-04-02 11:42 ` [PATCH v3 1/2] staging: octeon: ethernet-spi: replace pr_err with dev_err Ayush Mukkanwar
2026-04-02 11:42 ` [PATCH v3 2/2] staging: octeon: ethernet: replace pr_* with dev_* and netdev_* Ayush Mukkanwar
2026-04-02 11:50 ` Greg KH [this message]
2026-04-02 13:17 ` [PATCH v3 0/2] staging: octeon: " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026040207-shank-urethane-3014@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ayushmukkanwar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox