From: Andrei Khomenkov <khomenkov@mailbox.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Luka Gejak <luka.gejak@linux.dev>,
Ethan Tidmore <ethantidmore06@gmail.com>,
Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev
Subject: [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style
Date: Thu, 2 Apr 2026 18:04:23 +0300 [thread overview]
Message-ID: <20260402150429.14761-1-khomenkov@mailbox.org> (raw)
This series of patches cleans up the rtl8723bs driver code to improve
readability and better aligns with the Linux kernel coding style.
The first three patches simplify boolean comparisons, and the next
three perform general code cleanup.
I figured I needed to split the changes into directories, so I did
that. I also think each commit should do only one thing, so in the
last three commits, I fixed the style that wasn't related to the
logical changes with ' == true' and ' == false' that were in the first
three commits. However, if both the logic and the style need to be
fixed in the same commit, let me know, and I'll make v4.
Link: https://lore.kernel.org/linux-staging/20260330184640.17795-1-khomenkov@mailbox.org/
v3:
- Split the commits into even more commits, each commit
affecting one driver directory.
v2:
- Split the single patch into a two-patch series to separate
logical changes, as suggested by Luka Gejak.
- Cleaned up additional boolean comparisons found using 'git grep'.
Andrei Khomenkov (6):
staging: rtl8723bs: core: simplify boolean comparisons
staging: rtl8723bs: hal: simplify boolean comparisons
staging: rtl8723bs: os_dep: simplify boolean comparisons
staging: rtl8723bs: core: style cleanup
staging: rtl8723bs: hal: style cleanup
staging: rtl8723bs: os_dep: style cleanup
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_btcoex.c | 4 +-
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
.../staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
.../staging/rtl8723bs/core/rtw_ioctl_set.c | 54 ++++++------
drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 ++--
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16 ++--
drivers/staging/rtl8723bs/core/rtw_recv.c | 83 +++++++++----------
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
.../staging/rtl8723bs/core/rtw_wlan_util.c | 18 ++--
drivers/staging/rtl8723bs/core/rtw_xmit.c | 37 +++++----
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 10 +--
drivers/staging/rtl8723bs/hal/hal_com.c | 4 +-
.../staging/rtl8723bs/hal/hal_com_phycfg.c | 4 +-
drivers/staging/rtl8723bs/hal/hal_intf.c | 4 +-
drivers/staging/rtl8723bs/hal/odm.c | 13 ++-
.../staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
drivers/staging/rtl8723bs/hal/odm_DIG.c | 32 ++++---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 14 ++--
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 +--
.../staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +-
.../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 +-
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +-
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 54 ++++++------
.../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 4 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 +-
27 files changed, 200 insertions(+), 211 deletions(-)
--
2.53.0
next reply other threads:[~2026-04-02 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 15:04 Andrei Khomenkov [this message]
2026-04-02 15:04 ` [PATCH v3 1/6] staging: rtl8723bs: core: simplify boolean comparisons Andrei Khomenkov
2026-04-02 16:41 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 2/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 3/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 4/6] staging: rtl8723bs: core: style cleanup Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 5/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 16:46 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 6/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 21:43 ` [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Ethan Tidmore
2026-04-03 6:40 ` Greg Kroah-Hartman
2026-04-03 7:14 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402150429.14761-1-khomenkov@mailbox.org \
--to=khomenkov@mailbox.org \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox