[PATCH v2] staging: atomisp: fix alignment in function signature

[PATCH v2] staging: atomisp: fix alignment in function signature

[Joshua Crofts]

Fix alignment checks in function signatures

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp_fops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index c7aef066f2..c51d04af6c 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -96,8 +96,8 @@ static int atomisp_buf_init(struct vb2_buffer *vb)
 }
 
 static int atomisp_q_one_metadata_buffer(struct atomisp_sub_device *asd,
-	enum atomisp_input_stream_id stream_id,
-	enum ia_css_pipe_id css_pipe_id)
+					 enum atomisp_input_stream_id stream_id,
+					 enum ia_css_pipe_id css_pipe_id)
 {
 	struct atomisp_metadata_buf *metadata_buf;
 	enum atomisp_metadata_type md_type = ATOMISP_MAIN_METADATA;
-- 
2.47.3

Re: [PATCH v2] staging: atomisp: fix alignment in function signature

[Greg KH]

On Thu, Apr 02, 2026 at 12:08:06PM +0000, Joshua Crofts wrote:
> Fix alignment checks in function signatures
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_fops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> index c7aef066f2..c51d04af6c 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> @@ -96,8 +96,8 @@ static int atomisp_buf_init(struct vb2_buffer *vb)
>  }
>  
>  static int atomisp_q_one_metadata_buffer(struct atomisp_sub_device *asd,
> -	enum atomisp_input_stream_id stream_id,
> -	enum ia_css_pipe_id css_pipe_id)
> +					 enum atomisp_input_stream_id stream_id,
> +					 enum ia_css_pipe_id css_pipe_id)
>  {
>  	struct atomisp_metadata_buf *metadata_buf;
>  	enum atomisp_metadata_type md_type = ATOMISP_MAIN_METADATA;
> -- 
> 2.47.3
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH v2] staging: atomisp: fix alignment in function signature

[Joshua Crofts]

Fix alignment checks in function signatures

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
v2:
- Rebased patch onto the staging-next branch to resolve CI merge conflict.
- No functional changes to the code.

 drivers/staging/media/atomisp/pci/atomisp_fops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index c7aef066f2..c51d04af6c 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -96,8 +96,8 @@ static int atomisp_buf_init(struct vb2_buffer *vb)
 }
 
 static int atomisp_q_one_metadata_buffer(struct atomisp_sub_device *asd,
-	enum atomisp_input_stream_id stream_id,
-	enum ia_css_pipe_id css_pipe_id)
+					 enum atomisp_input_stream_id stream_id,
+					 enum ia_css_pipe_id css_pipe_id)
 {
 	struct atomisp_metadata_buf *metadata_buf;
 	enum atomisp_metadata_type md_type = ATOMISP_MAIN_METADATA;
-- 
2.47.3

Re: [PATCH v2] staging: atomisp: fix alignment in function signature

[Andy Shevchenko]

On Thu, Apr 02, 2026 at 12:23:33PM +0000, Joshua Crofts wrote:
> Fix alignment checks in function signatures
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
> v2:
> - Rebased patch onto the staging-next branch to resolve CI merge conflict.

Wrong branch for this driver, you need to use one from git.linuxtv.org.

> - No functional changes to the code.

Also the comments I gave against v1 are still valid.

Plus now the request you to read Submitting Patches and other process
documentation, so you will know that it is required at least 24h between
versions of the patch to give a chance others to review.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] staging: atomisp: fix alignment in function signature

[Joshua Crofts]

On Thu, 2 Apr 2026 at 14:54, Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:

> Wrong branch for this driver, you need to use one from git.linuxtv.org.
> Also the comments I gave against v1 are still valid.

I've replied to your comments on the v1 thread.

> Plus now the request you to read Submitting Patches and other process
> documentation, so you will know that it is required at least 24h between
> versions of the patch to give a chance others to review.

Apologies, please drop this patch, still learning the process. Thank you for
your time.

Kind regards

CJD