From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Andrei Khomenkov <khomenkov@mailbox.org>,
Luka Gejak <luka.gejak@linux.dev>,
Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style
Date: Fri, 3 Apr 2026 08:40:46 +0200 [thread overview]
Message-ID: <2026040335-ipod-pregnant-d48c@gregkh> (raw)
In-Reply-To: <DHIZW7VQ8J91.ON752XZ2E2L8@gmail.com>
On Thu, Apr 02, 2026 at 04:43:06PM -0500, Ethan Tidmore wrote:
> On Thu Apr 2, 2026 at 10:04 AM CDT, Andrei Khomenkov wrote:
> > This series of patches cleans up the rtl8723bs driver code to improve
> > readability and better aligns with the Linux kernel coding style.
> > The first three patches simplify boolean comparisons, and the next
> > three perform general code cleanup.
> >
> > I figured I needed to split the changes into directories, so I did
> > that. I also think each commit should do only one thing, so in the
> > last three commits, I fixed the style that wasn't related to the
> > logical changes with ' == true' and ' == false' that were in the first
> > three commits. However, if both the logic and the style need to be
> > fixed in the same commit, let me know, and I'll make v4.
> >
> > Link: https://lore.kernel.org/linux-staging/20260330184640.17795-1-khomenkov@mailbox.org/
> >
> > v3:
> > - Split the commits into even more commits, each commit
> > affecting one driver directory.
> >
> > v2:
> > - Split the single patch into a two-patch series to separate
> > logical changes, as suggested by Luka Gejak.
> > - Cleaned up additional boolean comparisons found using 'git grep'.
> >
> > Andrei Khomenkov (6):
> > staging: rtl8723bs: core: simplify boolean comparisons
> > staging: rtl8723bs: hal: simplify boolean comparisons
> > staging: rtl8723bs: os_dep: simplify boolean comparisons
> > staging: rtl8723bs: core: style cleanup
> > staging: rtl8723bs: hal: style cleanup
> > staging: rtl8723bs: os_dep: style cleanup
>
> Instead of "staging: rtl8723bs: os_dep: style cleanup" do "staging:
> rtl8723bs: style cleanup in os_dep/". For this driver the standard
> prefix is "staging: rtl8723bs:".
Either is really fine, we are not _that_ picky :)
next prev parent reply other threads:[~2026-04-03 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 15:04 [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 1/6] staging: rtl8723bs: core: simplify boolean comparisons Andrei Khomenkov
2026-04-02 16:41 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 2/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 3/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 4/6] staging: rtl8723bs: core: style cleanup Andrei Khomenkov
2026-04-02 15:04 ` [PATCH v3 5/6] staging: rtl8723bs: hal: " Andrei Khomenkov
2026-04-02 16:46 ` Dan Carpenter
2026-04-02 15:04 ` [PATCH v3 6/6] staging: rtl8723bs: os_dep: " Andrei Khomenkov
2026-04-02 21:43 ` [PATCH v3 0/6] staging: rtl8723bs: cleanup code and style Ethan Tidmore
2026-04-03 6:40 ` Greg Kroah-Hartman [this message]
2026-04-03 7:14 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026040335-ipod-pregnant-d48c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=khomenkov@mailbox.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox