From: Nikolay Kulikov <nikolayof23@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 1/6] staging: rtl8723bs: remove unnecessary rtw_bug_check() function
Date: Tue, 7 Apr 2026 17:33:26 +0300 [thread overview]
Message-ID: <20260407143622.9767-2-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260407143622.9767-1-nikolayof23@gmail.com>
Remove the rtw_bug_check() function as it does nothing and always
returns 'true', making any checks on its result meaningless.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 ----------
drivers/staging/rtl8723bs/include/osdep_service.h | 9 ---------
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index ddfc56f0253d..8e9387ad2810 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -351,9 +351,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
u16 s_cap, d_cap;
__le16 tmps, tmpd;
- if (rtw_bug_check(dst, src, &s_cap, &d_cap) == false)
- return false;
-
memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2);
memcpy((u8 *)&tmpd, rtw_get_capability_from_ie(dst->ies), 2);
@@ -457,11 +454,6 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
- rtw_bug_check(&pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network);
-
if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true);
rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie),
@@ -486,8 +478,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
list_for_each(plist, phead) {
pnetwork = list_entry(plist, struct wlan_network, list);
- rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork);
-
if (is_same_network(&pnetwork->network, target, feature)) {
target_find = 1;
break;
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 955e8678dc26..9392af858995 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -69,15 +69,6 @@ static inline void flush_signals_thread(void)
}
#define rtw_warn_on(condition) WARN_ON(condition)
-
-static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *parg4)
-{
- int ret = true;
-
- return ret;
-
-}
-
#define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r))
extern void rtw_free_netdev(struct net_device *netdev);
--
2.53.0
next prev parent reply other threads:[~2026-04-07 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:33 [PATCH 0/6] staging: rtl8723bs: cleanup osdep_service.h Nikolay Kulikov
2026-04-07 14:33 ` Nikolay Kulikov [this message]
2026-04-07 14:33 ` [PATCH 2/6] staging: rtl8723bs: remove unused _rtw_init_queue() function header Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 3/6] staging: rtl8723bs: remove the header of non-existent _kfree() function Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 4/6] staging: rtl8723bs: remove unused rtw_sprintf() macro Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 5/6] staging: rtl8723bs: remove the rtw_warn_on() macro Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 6/6] staging: rtl8723bs: remove unused BIT33..BIT36 macros Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407143622.9767-2-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox