From: Nikolay Kulikov <nikolayof23@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 2/6] staging: rtl8723bs: remove unused _rtw_init_queue() function header
Date: Tue, 7 Apr 2026 17:33:27 +0300 [thread overview]
Message-ID: <20260407143622.9767-3-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260407143622.9767-1-nikolayof23@gmail.com>
The _rtw_init_queue() function header is declared in osdep_service.h,
but it is not defined anywhere and all the code using it is commented
out, so we can remove the header and the commented out code.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ---
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 1 -
drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ----
drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
4 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index f78194d508df..df9c59449de5 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -21,9 +21,6 @@ void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
spin_lock_init(&psta_recvpriv->lock);
- /* for (i = 0; i<MAX_RX_NUMBLKS; i++) */
- /* _rtw_init_queue(&psta_recvpriv->blk_strms[i]); */
-
INIT_LIST_HEAD(&psta_recvpriv->defrag_q.queue);
spin_lock_init(&psta_recvpriv->defrag_q.lock);
}
diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index 07a6db1d2317..1e5bc9f4cd4b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -67,7 +67,6 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv)
spin_lock_init(&pstapriv->sta_hash_lock);
- /* _rtw_init_queue(&pstapriv->asoc_q); */
pstapriv->asoc_sta_count = 0;
INIT_LIST_HEAD(&pstapriv->sleep_q.queue);
spin_lock_init(&pstapriv->sleep_q.lock);
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 7bce0343d59f..10a778619466 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -45,10 +45,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
init_completion(&pxmitpriv->xmit_comp);
init_completion(&pxmitpriv->terminate_xmitthread_comp);
- /*
- * Please insert all the queue initialization using _rtw_init_queue below
- */
-
pxmitpriv->adapter = padapter;
INIT_LIST_HEAD(&pxmitpriv->be_pending.queue);
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 9392af858995..664c67e48f06 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -60,8 +60,6 @@ int _rtw_netif_rx(struct net_device *ndev, struct sk_buff *skb);
#define rtw_netif_rx(ndev, skb) _rtw_netif_rx(ndev, skb)
-extern void _rtw_init_queue(struct __queue *pqueue);
-
static inline void flush_signals_thread(void)
{
if (signal_pending(current))
--
2.53.0
next prev parent reply other threads:[~2026-04-07 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:33 [PATCH 0/6] staging: rtl8723bs: cleanup osdep_service.h Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 1/6] staging: rtl8723bs: remove unnecessary rtw_bug_check() function Nikolay Kulikov
2026-04-07 14:33 ` Nikolay Kulikov [this message]
2026-04-07 14:33 ` [PATCH 3/6] staging: rtl8723bs: remove the header of non-existent _kfree() function Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 4/6] staging: rtl8723bs: remove unused rtw_sprintf() macro Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 5/6] staging: rtl8723bs: remove the rtw_warn_on() macro Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 6/6] staging: rtl8723bs: remove unused BIT33..BIT36 macros Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407143622.9767-3-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox