From: Nikolay Kulikov <nikolayof23@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 5/6] staging: rtl8723bs: remove the rtw_warn_on() macro
Date: Tue, 7 Apr 2026 17:33:30 +0300 [thread overview]
Message-ID: <20260407143622.9767-6-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260407143622.9767-1-nikolayof23@gmail.com>
Remove the rtw_warn_on() macro, which simply calls WARN_ON(), and
replace all its uses with the standard WARN_ON().
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++--
drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
drivers/staging/rtl8723bs/include/osdep_service.h | 1 -
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 ++++----
8 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..72d5905a48e9 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1603,7 +1603,7 @@ static void rtw_btinfo_hdl(struct adapter *adapter, u8 *buf, u16 buf_len)
cmd_idx = info->cid;
if (info->len > buf_len - 2) {
- rtw_warn_on(1);
+ WARN_ON(1);
len = buf_len - 2;
} else {
len = info->len;
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 8e9387ad2810..3ecf4f979c03 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1697,7 +1697,7 @@ int rtw_select_roaming_candidate(struct mlme_priv *mlme)
struct wlan_network *candidate = NULL;
if (!mlme->cur_network_scanned) {
- rtw_warn_on(1);
+ WARN_ON(1);
return ret;
}
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 5f00fe282d1b..3d7beb83887d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -3082,7 +3082,7 @@ int issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned int pow
else
rtw_hal_macid_wakeup(padapter, psta->mac_id);
} else {
- rtw_warn_on(1);
+ WARN_ON(1);
}
do {
@@ -5890,7 +5890,7 @@ int rtw_chk_start_clnt_join(struct adapter *padapter, u8 *ch, u8 *bw, u8 *offset
bool connect_allow = true;
if (!ch || !bw || !offset) {
- rtw_warn_on(1);
+ WARN_ON(1);
connect_allow = false;
}
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 6a7c09db4cd9..c04419c9c3fc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -577,7 +577,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid)
netdev_dbg(adapter->pnetdev,
FUNC_ADPT_FMT " group key with invalid key id:%u\n",
FUNC_ADPT_ARG(adapter), kid);
- rtw_warn_on(1);
+ WARN_ON(1);
goto bitmap_handle;
}
@@ -623,7 +623,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid)
netdev_dbg(adapter->pnetdev,
FUNC_ADPT_FMT " group key id:%u no room\n",
FUNC_ADPT_ARG(adapter), kid);
- rtw_warn_on(1);
+ WARN_ON(1);
goto bitmap_handle;
}
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 10a778619466..f3a143d41f48 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -2035,7 +2035,7 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *xmitframe)
allow = true;
else if (registry->hiq_filter == RTW_HIQ_FILTER_DENY_ALL) {
} else
- rtw_warn_on(1);
+ WARN_ON(1);
return allow;
}
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 728a2171fbcb..4e3cd1547e01 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -576,7 +576,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val)
switch (variable) {
case HW_VAR_INIT_RTS_RATE:
- rtw_warn_on(1);
+ WARN_ON(1);
break;
case HW_VAR_SEC_CFG:
{
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index cd73fa294a56..99c26b446f72 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -64,7 +64,6 @@ static inline void flush_signals_thread(void)
flush_signals(current);
}
-#define rtw_warn_on(condition) WARN_ON(condition)
#define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r))
extern void rtw_free_netdev(struct net_device *netdev);
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 098456e97c96..4f16803b96a2 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -377,7 +377,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter *padapter)
rtw_cfg80211_inform_bss(padapter, cur_network);
} else {
if (!scanned) {
- rtw_warn_on(1);
+ WARN_ON(1);
return;
}
if (!memcmp(&scanned->network.ssid, &pnetwork->ssid,
@@ -385,7 +385,7 @@ void rtw_cfg80211_ibss_indicate_connect(struct adapter *padapter)
!memcmp(scanned->network.mac_address, pnetwork->mac_address, ETH_ALEN))
rtw_cfg80211_inform_bss(padapter, scanned);
else
- rtw_warn_on(1);
+ WARN_ON(1);
}
if (!rtw_cfg80211_check_bss(padapter))
@@ -418,7 +418,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *padapter)
struct wlan_network *scanned = pmlmepriv->cur_network_scanned;
if (!scanned) {
- rtw_warn_on(1);
+ WARN_ON(1);
goto check_bss;
}
@@ -427,7 +427,7 @@ void rtw_cfg80211_indicate_connect(struct adapter *padapter)
sizeof(struct ndis_802_11_ssid)))
rtw_cfg80211_inform_bss(padapter, scanned);
else
- rtw_warn_on(1);
+ WARN_ON(1);
}
check_bss:
--
2.53.0
next prev parent reply other threads:[~2026-04-07 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:33 [PATCH 0/6] staging: rtl8723bs: cleanup osdep_service.h Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 1/6] staging: rtl8723bs: remove unnecessary rtw_bug_check() function Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 2/6] staging: rtl8723bs: remove unused _rtw_init_queue() function header Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 3/6] staging: rtl8723bs: remove the header of non-existent _kfree() function Nikolay Kulikov
2026-04-07 14:33 ` [PATCH 4/6] staging: rtl8723bs: remove unused rtw_sprintf() macro Nikolay Kulikov
2026-04-07 14:33 ` Nikolay Kulikov [this message]
2026-04-07 14:33 ` [PATCH 6/6] staging: rtl8723bs: remove unused BIT33..BIT36 macros Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407143622.9767-6-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox