From: Hungyu Lin <dennylin0707@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno
Date: Wed, 8 Apr 2026 11:13:08 +0000 [thread overview]
Message-ID: <20260408111314.19329-1-dennylin0707@gmail.com> (raw)
Convert the xmit initialization path to use standard kernel
return conventions: 0 on success and negative errno on failure.
This replaces the use of _SUCCESS/_FAIL with proper error
codes and improves error propagation.
The changes are split into smaller patches following review
feedback from Dan Carpenter, converting one function at a time
to make the series easier to review.
v5:
- Fix trailing whitespace in os_intfs.c
v4:
- Split into a series of smaller patches as suggested by Dan Carpenter
- Convert functions step by step to improve reviewability
- Ensure each patch builds independently
v3:
- Rebase onto latest staging-next to resolve conflicts.
v2:
- Rework xmit init path to remove _SUCCESS/_FAIL usage
- Convert allocation helpers to return standard error codes
- Update caller to use direct failure checks
- Address review feedback from Ethan Tidmore
Hungyu Lin (6):
staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow
staging: rtl8723bs: make rtw_alloc_hwxmits static
staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno
staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c
staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno
staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno
drivers/staging/rtl8723bs/core/rtw_xmit.c | 138 +++++++++---------
drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 -
.../staging/rtl8723bs/include/xmit_osdep.h | 1 -
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 13 --
5 files changed, 74 insertions(+), 84 deletions(-)
--
2.34.1
next reply other threads:[~2026-04-08 11:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 11:13 Hungyu Lin [this message]
2026-04-08 11:13 ` [PATCH v5 1/6] staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 2/6] staging: rtl8723bs: make rtw_alloc_hwxmits static Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 3/6] staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 4/6] staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 5/6] staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno Hungyu Lin
2026-04-08 11:13 ` [PATCH v5 6/6] staging: rtl8723bs: convert _rtw_init_xmit_priv " Hungyu Lin
2026-04-08 13:48 ` [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408111314.19329-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=ethantidmore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox