From: "Bera Yüzlü" <b9788213@gmail.com>
To: contact.pranavdesai@gmail.com
Cc: b9788213@gmail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: style cleanups in HalPhyRf_8723B.c
Date: Wed, 8 Apr 2026 16:00:27 +0300 [thread overview]
Message-ID: <20260408130026.1847-2-b9788213@gmail.com> (raw)
In-Reply-To: <20260408064557.40928-1-contact.pranavdesai@gmail.com>
On Wed, 8 Apr 2026 12:15:57 +0530, PranavDesai-Git wrote:
> This patch cleans up several checkpatch.pl warnings in the
> rtl8723bs driver. It removes unnecessary braces from
> single-statement blocks, fixes space-before-tab formatting,
> and removes commented-out dead code blocks.
Don't do unrelated changes at once.
> Signed-off-by: PranavDesai-Git <contact.pranavdesai@gmail.com>
Use 'Pranav Desai'.
- /* enable path A PA in TXIQK mode */
+ /* enable path A PA in TXIQK mode */
You should remove the tab here.
- /* disable path B PA in TXIQK mode */
-/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, bRFRegOffsetMask, 0x00020); */
-/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x40ec1); */
+ /* disable path B PA in TXIQK mode */
+/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, bRFRegOffsetMask, 0x00020); */
+/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x40ec1); */
For comments like this just delete them all.
Make sure you are using staging-next branch.
Thanks,
Bera
prev parent reply other threads:[~2026-04-08 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 6:45 [PATCH] staging: rtl8723bs: style cleanups in HalPhyRf_8723B.c PranavDesai-Git
2026-04-08 13:00 ` Bera Yüzlü [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408130026.1847-2-b9788213@gmail.com \
--to=b9788213@gmail.com \
--cc=contact.pranavdesai@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox