From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Denny Lin <dennylin0707@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750fb: propagate error codes from de_wait()
Date: Thu, 9 Apr 2026 17:22:39 +0200 [thread overview]
Message-ID: <2026040929-cartel-scariness-571c@gregkh> (raw)
In-Reply-To: <CAGEkeHd8p48H6U36VBFAAMffz_tW71jcb90POekDgG51JN4YUA@mail.gmail.com>
On Thu, Apr 09, 2026 at 08:15:36AM -0700, Denny Lin wrote:
> Hi Greg,
>
Odd email style, try replying inline in the real email, not at the top
please :)
> > Why did you delete the comment?
>
> The comment was removed as part of simplifying the code while
> changing the error handling to propagate the return value from
> de_wait(). I can restore or update it if needed.
Please keep it.
> > And when did de_wait() start returning correct values?
>
> de_wait() starts returning a proper errno value in patch 1 of this
> series, where the timeout return value is changed from -1 to
> -ETIMEDOUT. This patch then propagates that error value.
Ah, that wasn't obvious, sorry.
thanks,
greg k-h
prev parent reply other threads:[~2026-04-09 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 14:41 [PATCH 0/2] staging: sm750fb: improve error handling in de_wait path Hungyu Lin
2026-04-09 14:41 ` [PATCH 1/2] staging: sm750fb: return -ETIMEDOUT on timeout in de_wait functions Hungyu Lin
2026-04-09 14:41 ` [PATCH 2/2] staging: sm750fb: propagate error codes from de_wait() Hungyu Lin
2026-04-09 15:05 ` Greg Kroah-Hartman
2026-04-09 15:15 ` Denny Lin
2026-04-09 15:22 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026040929-cartel-scariness-571c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dennylin0707@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox