From: Joshua Crofts <joshua.crofts1@gmail.com>
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Joshua Crofts <joshua.crofts1@gmail.com>
Subject: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math
Date: Sat, 11 Apr 2026 10:58:48 +0200 [thread overview]
Message-ID: <20260411085848.75381-3-joshua.crofts1@gmail.com> (raw)
In-Reply-To: <20260411085848.75381-1-joshua.crofts1@gmail.com>
Refactor the ad9832_calc_freqreg by adding a BIT_ULL()
macro instead of manual bit shifting for better
readability.
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
v2:
- changed ull to u64 type
drivers/staging/iio/frequency/ad9832.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index 8873a6d11e..4221e51dc4 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -112,8 +112,8 @@ struct ad9832_state {
static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout)
{
- unsigned long long freqreg = (u64)fout *
- (u64)((u64)1L << AD9832_FREQ_BITS);
+ u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i;
+
do_div(freqreg, mclk);
return freqreg;
}
--
2.34.1
next prev parent reply other threads:[~2026-04-11 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:58 [RESEND PATCH v2 0/2] iio: frequency: ad9832: cleanups Joshua Crofts
2026-04-11 8:58 ` [RESEND PATCH v2 1/2] iio: frequency: ad9832: remove kernel.h proxy header Joshua Crofts
2026-04-11 8:58 ` Joshua Crofts [this message]
2026-04-11 10:38 ` [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math Dan Carpenter
2026-04-11 10:47 ` Joshua Crofts
2026-04-11 10:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411085848.75381-3-joshua.crofts1@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox