From: Josh Hesketh <josh.hesketh@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
Luka Gejak <lukagejak5@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Josh Hesketh <josh.hesketh@gmail.com>
Subject: [PATCH v2 3/3] staging: rtl8723bs: remove unnecessary else after return in sdio_halinit.c
Date: Sun, 12 Apr 2026 16:06:33 +0100 [thread overview]
Message-ID: <20260412150633.12071-3-josh.hesketh@gmail.com> (raw)
In-Reply-To: <20260412150633.12071-1-josh.hesketh@gmail.com>
Remove else branch following a conditional return statement
Signed-off-by: Josh Hesketh <josh.hesketh@gmail.com>
---
v2:
- Rebased on staging-next
- Split from original patch 1/2
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 4a4f6b03253a..ed82860ae9b6 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -641,11 +641,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
padapter->bFWReady = false;
pHalData->fw_ractrl = false;
return ret;
- } else {
- padapter->bFWReady = true;
- pHalData->fw_ractrl = true;
}
+ padapter->bFWReady = true;
+ pHalData->fw_ractrl = true;
+
rtl8723b_InitializeFirmwareVars(padapter);
if (pwrctrlpriv->reg_rfoff)
--
2.53.0
next prev parent reply other threads:[~2026-04-12 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 15:06 [PATCH v2 1/3] staging: rtl8723bs: remove commented out dead code in sdio_halinit.c Josh Hesketh
2026-04-12 15:06 ` [PATCH v2 2/3] staging: rtl8723bs: fix whitespace issues " Josh Hesketh
2026-04-12 16:05 ` Luka Gejak
2026-04-12 15:06 ` Josh Hesketh [this message]
2026-04-12 16:06 ` [PATCH v2 3/3] staging: rtl8723bs: remove unnecessary else after return " Luka Gejak
2026-04-12 16:13 ` Luka Gejak
2026-04-12 16:05 ` [PATCH v2 1/3] staging: rtl8723bs: remove commented out dead code " Luka Gejak
2026-04-12 16:12 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412150633.12071-3-josh.hesketh@gmail.com \
--to=josh.hesketh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox