From: David Laight <david.laight.linux@gmail.com>
To: Nguyen Duc Thinh <ducthinh100812@gmail.com>
Cc: Luka Gejak <luka.gejak@linux.dev>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase
Date: Sun, 12 Apr 2026 15:37:53 +0100 [thread overview]
Message-ID: <20260412153753.17c2c122@pumpkin> (raw)
In-Reply-To: <20260412130012.5832-3-ducthinh100812@gmail.com>
On Sun, 12 Apr 2026 20:00:12 +0700
Nguyen Duc Thinh <ducthinh100812@gmail.com> wrote:
> The variable dot11AuthAlgrthm and its associated enum values
> violate the kernel naming convention. Rename them to the
> snake_case equivalent, dot11_auth_algrthm.
...
> - if (!(psta->state & _FW_LINKED))
> + if !(psta->state & _FW_LINKED)
You didn't even compile it.
There are lot of unrelated changed that make this far too big as well.
David
next prev parent reply other threads:[~2026-04-12 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 13:00 [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in enqueue() Nguyen Duc Thinh
2026-04-12 13:00 ` [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in poison_channel() Nguyen Duc Thinh
2026-04-12 13:00 ` [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase Nguyen Duc Thinh
2026-04-12 14:37 ` David Laight [this message]
2026-04-12 18:52 ` [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in enqueue() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412153753.17c2c122@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=ducthinh100812@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox